[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: D3504: Implment DRM EGL scaling
From: Roman Gilg <noreply () phabricator ! kde ! org>
Date: 2017-03-25 16:58:22
Message-ID: 20170325165822.31406.8302.96F2067E () phabricator ! kde ! org
[Download RAW message or body]
subdiff added a comment.
Just a heads up: Atomic mode setting allows to scale buffers / content of a plane \
directly instead of using GL. But I assume this would be possible to add later.
Something else: How does this work, when Gl / compositing is skipped (i.e. in my \
case for the direct scanout of a wayland buffer)? Is it then not scaling at all? We \
need to make sure that in this case the dimensions are still fine. Otherwise we need \
to restrict direct scanout to AMS only.
INLINE COMMENTS
> egl_gbm_backend.cpp:159
> o.output = drmOutput;
> - o.gbmSurface = gbm_surface_create(m_backend->gbmDevice(), \
> drmOutput->size().width(), drmOutput->size().height(), + auto size = \
> drmOutput->size() * drmOutput->scale(); +
You could add to `struct Output` a value for that, which you then use in \
makeContextCurrent.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3504
To: davidedmundson, #plasma, graesslin
Cc: subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3504" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Just a heads up: Atomic mode setting \
allows to scale buffers / content of a plane directly instead of using GL. But I \
assume this would be possible to add later.</p>
<p>Something else: How does this work, when Gl / compositing is skipped (i.e. in my \
case for the direct scanout of a wayland buffer)? Is it then not scaling at all? We \
need to make sure that in this case the dimensions are still fine. Otherwise we need \
to restrict direct scanout to AMS only.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3504#inline-21269" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">egl_gbm_backend.cpp:159</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="n">o</span><span class="p">.</span><span \
class="n">output</span> <span style="color: #aa2211">=</span> <span \
class="n">drmOutput</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="bright"></span><span class="n"><span class="bright">o</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">gbmSurface</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">gbm_surface_create</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">m_backend</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">gbmDevice</span></span><span \
class="bright"></span><span class="p"><span class="bright">(),</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">drmOutput</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">size</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">width</span></span><span class="bright"></span><span \
class="p"><span class="bright">(),</span></span><span class="bright"> </span><span \
class="n"><span class="bright">drmOutput</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">size</span></span><span class="bright"></span><span class="p"><span \
class="bright">().</span></span><span class="bright"></span><span class="n"><span \
class="bright">height</span></span><span class="bright"></span><span class="p"><span \
class="bright">(),</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> \
</span><span class="n"><span class="bright">size</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">=</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">drmOutput</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">size</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> \
</span><span class="n"><span class="bright">drmOutput</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">scale</span></span><span class="bright"></span><span class="p"><span \
class="bright">();</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
could add to <tt style="background: #ebebeb; font-size: 13px;">struct Output</tt> a \
value for that, which you then use in \
makeContextCurrent.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3504" \
rel="noreferrer">https://phabricator.kde.org/D3504</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: \
</strong>subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic