[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D3498: Add scaling to DRM backend
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-03-25 16:55:40
Message-ID: 20170325165539.64010.57431.346A2DE6 () phabricator ! kde ! org
[Download RAW message or body]

subdiff requested changes to this revision.
subdiff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scene_qpainter_drm_backend.cpp:67
> auto initBuffer = [&o, output, this] (int index) {
> -        o.buffer[index] = m_backend->createBuffer(output->size());
> +        o.buffer[index] = m_backend->createBuffer(output->size() * \
> output->scale()); o.buffer[index]->map();

Divding above through scale and then multiplying again here and in blank() could lead \
to rounding errors.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3498

To: davidedmundson, #plasma, graesslin, subdiff
Cc: subdiff, #kwin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">subdiff requested changes to this revision.<br />subdiff \
added inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3498" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3498#inline-21270" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">scene_qpainter_drm_backend.cpp:67</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span style="color: #aa4000">auto</span> <span \
class="n">initBuffer</span> <span style="color: #aa2211">=</span> <span \
class="p">[</span><span style="color: #aa2211">&amp;</span><span \
class="n">o</span><span class="p">,</span> <span class="n">output</span><span \
class="p">,</span> <span style="color: #aa4000">this</span><span class="p">]</span> \
<span class="p">(</span><span style="color: #aa4000">int</span> <span \
class="n">index</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        \
<span class="n">o</span><span class="p">.</span><span class="n">buffer</span><span \
class="p">[</span><span class="n">index</span><span class="p">]</span> <span \
style="color: #aa2211">=</span> <span class="n">m_backend</span><span style="color: \
#aa2211">-&gt;</span><span class="n">createBuffer</span><span class="p">(</span><span \
class="n">output</span><span style="color: #aa2211">-&gt;</span><span \
class="n">size</span><span class="p">());</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">o</span><span class="p">.</span><span class="n">buffer</span><span \
class="p">[</span><span class="n">index</span><span class="p">]</span> <span \
style="color: #aa2211">=</span> <span class="n">m_backend</span><span style="color: \
#aa2211">-&gt;</span><span class="n">createBuffer</span><span class="p">(</span><span \
class="n">output</span><span style="color: #aa2211">-&gt;</span><span \
class="n">size</span><span class="p">()<span class="bright"></span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">*</span></span><span class="bright"> </span><span class="n"><span \
class="bright">output</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-&gt;</span></span><span class="bright"></span><span \
class="n"><span class="bright">scale</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">        <span class="n">o</span><span class="p">.</span><span \
class="n">buffer</span><span class="p">[</span><span class="n">index</span><span \
class="p">]</span><span style="color: #aa2211">-&gt;</span><span \
class="n">map</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Divding above through scale and then multiplying again here and in blank() \
could lead to rounding errors.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3498" \
rel="noreferrer">https://phabricator.kde.org/D3498</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin, subdiff<br \
/><strong>Cc: </strong>subdiff, KWin, plasma-devel, kwin, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]