[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127662: [kwin] Fix build with future glibc (major/minor macros)
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-06-20 14:20:48
Message-ID: 20160620142048.22783.14883 () mimi ! kde ! org
[Download RAW message or body]
--===============6616953040047417982==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juni 20, 2016, 9:27 vorm., Martin Gräßlin wrote:
> > I just reverted this change as it breaks on FreeBSD.
Have BSD try:
#ifndef major
#include <sys/sysmacros.h>
#endif
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127662/#review96742
-----------------------------------------------------------
On April 20, 2016, 5:09 nachm., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127662/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 5:09 nachm.)
>
>
> Review request for kwin.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> ...where sys/sysmacros.h is going to be removed from sys/types.h
>
> See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html
>
>
> Diffs
> -----
>
> logind.cpp 22a86cdfceaac3138a186cb2f7ab3eae674a1c77
> virtual_terminal.cpp 40628315620e3d943b7ae0462c4415072fc256b8
>
> Diff: https://git.reviewboard.kde.org/r/127662/diff/
>
>
> Testing
> -------
>
> builds fine with older glibc (tested with glibc-2.21) as well as a patched \
> glibc-2.23 with the removal already implemented.
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============6616953040047417982==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127662/">https://git.reviewboard.kde.org/r/127662/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juni 20th, 2016, 9:27 vorm. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just reverted this change as it breaks on \
FreeBSD.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have \
BSD try:</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">ifndef major</h1> <h1 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">include <sys/sysmacros.h></h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">endif</h1></pre> <br />
<p>- Thomas</p>
<br />
<p>On April 20th, 2016, 5:09 nachm. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated April 20, 2016, 5:09 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">...where sys/sysmacros.h is going to be removed from \
sys/types.h</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also: \
https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds fine with older glibc (tested with glibc-2.21) \
as well as a patched glibc-2.23 with the removal already implemented.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>logind.cpp <span style="color: \
grey">(22a86cdfceaac3138a186cb2f7ab3eae674a1c77)</span></li>
<li>virtual_terminal.cpp <span style="color: \
grey">(40628315620e3d943b7ae0462c4415072fc256b8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127662/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6616953040047417982==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic