--===============6325474982272626171== Content-Type: multipart/alternative; boundary="===============6616953040047417982==" --===============6616953040047417982== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Juni 20, 2016, 9:27 vorm., Martin Gräßlin wrote: > > I just reverted this change as it breaks on FreeBSD. Have BSD try: #ifndef major #include #endif - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127662/#review96742 ----------------------------------------------------------- On April 20, 2016, 5:09 nachm., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127662/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 5:09 nachm.) > > > Review request for kwin. > > > Repository: kwin > > > Description > ------- > > ...where sys/sysmacros.h is going to be removed from sys/types.h > > See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html > > > Diffs > ----- > > logind.cpp 22a86cdfceaac3138a186cb2f7ab3eae674a1c77 > virtual_terminal.cpp 40628315620e3d943b7ae0462c4415072fc256b8 > > Diff: https://git.reviewboard.kde.org/r/127662/diff/ > > > Testing > ------- > > builds fine with older glibc (tested with glibc-2.21) as well as a patched glibc-2.23 with the removal already implemented. > > > Thanks, > > Andreas Sturmlechner > > --===============6616953040047417982== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127662/

On Juni 20th, 2016, 9:27 vorm. UTC, Martin Gräßlin wrote:
I just reverted this change as it breaks on FreeBSD.

Have BSD try:
ifndef major
include <sys/sysmacros.h>
endif

- Thomas

On April 20th, 2016, 5:09 nachm. UTC, Andreas Sturmlechner wrote:

Review request for kwin.

By Andreas Sturmlechner.

Updated April 20, 2016, 5:09 nachm.

Repository: kwin

Description

...where sys/sysmacros.h is going to be removed from sys/types.h

See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html

Testing

builds fine with older glibc (tested with glibc-2.21) as well as a patched glibc-2.23 with the removal already implemented.

Diffs

logind.cpp (22a86cdfceaac3138a186cb2f7ab3eae674a1c77)
virtual_terminal.cpp (40628315620e3d943b7ae0462c4415072fc256b8)

View Diff

--===============6616953040047417982==-- --===============6325474982272626171== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3dpbiBtYWls aW5nIGxpc3QKa3dpbkBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlzdGlu Zm8va3dpbgo= --===============6325474982272626171==--