'Re: Review Request 126981: [WIP] pimp AnimationEffect for morphine? morpheus? the other patch ; -)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 126981: [WIP] pimp AnimationEffect for morphine? morpheus? the other patch ; -)
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2016-02-09 15:53:30
Message-ID: 20160209155330.23891.37225 () mimi ! kde ! org
[Download RAW message or body]

--===============0788197432625938291==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Feb. 9, 2016, 12:54 p.m., Marco Martin wrote:
> > hmm, in order to use the remaining time i would need something to access how much \
> > time the old animation already endured?

No, the idea is that you pass the time your want to have the animation run from this \
moment on, ie. in doubt the general animation time (linear prolongation with every \
incident)

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126981/#review92194
-----------------------------------------------------------

On Feb. 3, 2016, 6:28 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126981/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 6:28 p.m.)
> 
> 
> Review request for kwin, Martin Gräßlin and Marco Martin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> commit 32e4143ca80048774df2425c8f7225baa6b10da9
> 
> export retarget to scripts
> 
> commit eaa36bbaeafa765e7005af25f8798f18224e8b17
> 
> allow to retarget animations
> 
> commit 09558d0326258fabaf81594dcb0ac2c42fbfd483
> 
> protect against cancellation of just ended animations
> 
> 
> Diffs
> -----
> 
> libkwineffects/kwinanimationeffect.h f59eedc 
> libkwineffects/kwinanimationeffect.cpp 579535b 
> scripting/scriptedeffect.h 2a77a2f 
> scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126981/diff/
> 
> 
> Testing
> -------
> 
> Compiles, validation encapsulation does not seem to break things
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

--===============0788197432625938291==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126981/">https://git.reviewboard.kde.org/r/126981/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 9th, 2016, 12:54 p.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">hmm, in order to use the remaining time i would need \
something to access how much time the old animation already endured?</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
the idea is that you pass the time your want to have the animation run from this \
moment on, ie. in doubt the general animation time (linear prolongation with every \
incident)</p></pre> <br />

<p>- Thomas</p>

<br />
<p>On February 3rd, 2016, 6:28 p.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Marco Martin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 3, 2016, 6:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit 32e4143ca80048774df2425c8f7225baa6b10da9</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">export retarget to scripts </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit eaa36bbaeafa765e7005af25f8798f18224e8b17</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">allow to retarget animations </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit 09558d0326258fabaf81594dcb0ac2c42fbfd483</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">protect against cancellation of just ended animations \
</pre></div> </p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, validation encapsulation does not seem to \
break things</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(f59eedc)</span></li>

 <li>libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(579535b)</span></li>

 <li>scripting/scriptedeffect.h <span style="color: grey">(2a77a2f)</span></li>

 <li>scripting/scriptedeffect.cpp <span style="color: grey">(7ab065b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126981/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0788197432625938291==--

[Attachment #3 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 