[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Re: Re: Re: Re: Notes from "New OSD in Plasma 2"
From:       Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date:       2014-01-23 13:03:45
Message-ID: 9228917.D7ZGQN4Qnx () martin-desktop
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 21 January 2014 17:29:12 Martin Klapetek wrote:
> On Tue, Jan 21, 2014 at 3:28 PM, Martin Klapetek
> 
> <martin.klapetek@gmail.com>wrote:
> > On Tue, Jan 21, 2014 at 3:10 PM, Martin Gräßlin <mgraesslin@kde.org>wrote:
> >> On Tuesday 21 January 2014 14:26:59 Martin Klapetek wrote:
> >> > On Tue, Jan 21, 2014 at 8:57 AM, Martin Gräßlin <mgraesslin@kde.org>
> >> 
> >> wrote:
> >> > > I had a look and the Plasma side seems fine. You can verify using
> >> 
> >> xprop.
> >> 
> >> > > My
> >> > > 
> >> > >  demo dialog got the notification type.
> >> > 
> >> > Hmm...I might have been wrong then, using xprop on the OSD I get
> >> > 
> >> > _NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE,
> >> > _NET_WM_WINDOW_TYPE_NORMAL
> >> 
> >> That's not what I had. My example code which I wrote this morning for
> >> testing:
> >> http://pastebin.kde.org/phhnfbtda
> >> 
> >> I executed the code using qmlscene. Maybe that makes a difference.
> > 
> > Ok, two things I noticed:
> > 
> > 1) If "visible: true" is not present, the type is never NET::Notification,
> > even in your code. Once added, it has proper type.
> > 2) This works when executed in qmlscene only, it does not work when
> > using KDeclarative::QmlObject for the dialog.
> > 
> > I'll investigate why.
> 
> Update: windowType for the Dialog is overiden by Qt
> (in QXcbWindow::setNetWmWindowFlags). That method (in combination with
> window flags) however does not support NET::Notification. Should we extend
> that system? Or should we make that method not /replace/ the type but just
> add it (would that even work?)? Should we work around that in our code?

Just for the record: it is a bug in PlasmaCore.Dialog - see 
https://git.reviewboard.kde.org/r/115258/

Cheers
Martin G.
["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]