From kwin  Thu Jan 23 13:03:45 2014
From: Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date: Thu, 23 Jan 2014 13:03:45 +0000
To: kwin
Subject: Re: Re: Re: Re: Re: Notes from "New OSD in Plasma 2"
Message-Id: <9228917.D7ZGQN4Qnx () martin-desktop>
X-MARC-Message: https://marc.info/?l=kwin&m=139048270002736
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0360414515317121254=="


--===============0360414515317121254==
Content-Type: multipart/signed; boundary="nextPart1891869.Ov5gzgKxkC"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart1891869.Ov5gzgKxkC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Tuesday 21 January 2014 17:29:12 Martin Klapetek wrote:
> On Tue, Jan 21, 2014 at 3:28 PM, Martin Klapetek
>=20
> <martin.klapetek@gmail.com>wrote:
> > On Tue, Jan 21, 2014 at 3:10 PM, Martin Gr=C3=A4=C3=9Flin <mgraessl=
in@kde.org>wrote:
> >> On Tuesday 21 January 2014 14:26:59 Martin Klapetek wrote:
> >> > On Tue, Jan 21, 2014 at 8:57 AM, Martin Gr=C3=A4=C3=9Flin <mgrae=
sslin@kde.org>
> >>=20
> >> wrote:
> >> > > I had a look and the Plasma side seems fine. You can verify us=
ing
> >>=20
> >> xprop.
> >>=20
> >> > > My
> >> > >=20
> >> > >  demo dialog got the notification type.
> >> >=20
> >> > Hmm...I might have been wrong then, using xprop on the OSD I get=

> >> >=20
> >> > _NET_WM_WINDOW_TYPE(ATOM) =3D _KDE_NET_WM_WINDOW_TYPE_OVERRIDE,
> >> > _NET_WM_WINDOW_TYPE_NORMAL
> >>=20
> >> That's not what I had. My example code which I wrote this morning =
for
> >> testing:
> >> http://pastebin.kde.org/phhnfbtda
> >>=20
> >> I executed the code using qmlscene. Maybe that makes a difference.=

> >=20
> > Ok, two things I noticed:
> >=20
> > 1) If "visible: true" is not present, the type is never NET::Notifi=
cation,
> > even in your code. Once added, it has proper type.
> > 2) This works when executed in qmlscene only, it does not work when=

> > using KDeclarative::QmlObject for the dialog.
> >=20
> > I'll investigate why.
>=20
> Update: windowType for the Dialog is overiden by Qt
> (in QXcbWindow::setNetWmWindowFlags). That method (in combination wit=
h
> window flags) however does not support NET::Notification. Should we e=
xtend
> that system? Or should we make that method not /replace/ the type but=
 just
> add it (would that even work?)? Should we work around that in our cod=
e?

Just for the record: it is a bug in PlasmaCore.Dialog - see=20
https://git.reviewboard.kde.org/r/115258/

Cheers
Martin G.
--nextPart1891869.Ov5gzgKxkC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlLhEzgACgkQqVXwidMiVrqSKwCeM/rwC4qW6WNxF4Z7z5b2QhIV
4NsAn3yDnNaOjVjs8SBQDdQphmK3iulM
=QXKM
-----END PGP SIGNATURE-----

--nextPart1891869.Ov5gzgKxkC--


--===============0360414515317121254==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============0360414515317121254==--