[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 112161: Allow special 0% quarter tiling (corner pixel only)
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-01-18 14:29:02
Message-ID: 20140118142902.23663.25462 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 23, 2013, 5:38 a.m., Martin Gräßlin wrote:
> > I fail to see why only in the 0 % case the area should be changed.
>
> Thomas Lübking wrote:
> The bug/wish demands the ability to only tile in the very corner pixels of the \
> screen (ie. of FullArea) while we currently tile on the edges of the MoveArea \
> because otherwise tiling might be "impossible" (depending on present struts, the \
> strut width and the mouse position on the window or even the window size) - see bug \
> #322493, resp. https://git.reviewboard.kde.org/r/111556/
> Martin Gräßlin wrote:
> I still fail to see why it should be related to the 0 % setting. Maybe I'm just too \
> dumb this morning after staying all of yesterday in bed due to strong headache.
> Thomas Lübking wrote:
> target conflict.
> FullArea all the time: hello bug #322493
> MoveArea all the time: hello bug #323710
>
> Since the focus of bug #323710 is the ability to only quartertile on the very \
> screencorners, a special case will allow for both (on price of facing bug #322493, \
> ie. the inability to tile under certain conditions)
> Alternatives:
> - base the area on strut sizes and mouse position relative to the window
> - shift back the window against the movement direction until the relative \
> mouseposition allows for tiling.
> The MoveArea is however likely more correct anyway, since it matches the area where \
> the window is tiled (though that's nitpicking as this is only about ratios)
> Martin Gräßlin wrote:
> After quite some thinking I'm very unsure whether the ability to:
> 1) just use quick tiling in the corner
> 2) having a special handling for this case
>
> is a valid usecase at all. I would even go so far and say that the corners should \
> be excluded from the quick tiling/maximization logic as it's in both areas. Is the \
> top left corner relevant for left edge or for top edge?
> So unless someone can come up with very good arguments, I tend to -1 for this \
> change.
> Thomas Lübking wrote:
> The only argument i have is bug #323710
> Declare it WONTFIX and i'll discard the RR - personally i don't care too much.
>
> This patch wil hold for the bottom corners on most setups, though ;-P
ping. should the bug become WONTFIX?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112161/#review38398
-----------------------------------------------------------
On Aug. 19, 2013, 5:15 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112161/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 5:15 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Bugs: 323710
> http://bugs.kde.org/show_bug.cgi?id=323710
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> simple patch, could go into 4.11/.1 but i'll not insist ;-)
>
>
> Diffs
> -----
>
> kwin/events.cpp 9048118
> kwin/kcmkwin/kwinscreenedges/main.ui 6985e8b
>
> Diff: https://git.reviewboard.kde.org/r/112161/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112161/">https://git.reviewboard.kde.org/r/112161/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 23rd, 2013, 5:38 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I fail to see why only in the 0 % case the area should be changed.</pre> \
</blockquote>
<p>On August 23rd, 2013, 6:21 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bug/wish demands the \
ability to only tile in the very corner pixels of the screen (ie. of FullArea) while \
we currently tile on the edges of the MoveArea because otherwise tiling might be \
"impossible" (depending on present struts, the strut width and the mouse \
position on the window or even the window size) - see bug #322493, resp. \
https://git.reviewboard.kde.org/r/111556/</pre> </blockquote>
<p>On August 23rd, 2013, 6:42 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still fail to see why \
it should be related to the 0 % setting. Maybe I'm just too dumb this morning \
after staying all of yesterday in bed due to strong headache.</pre> </blockquote>
<p>On August 23rd, 2013, 7:20 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">target conflict. \
FullArea all the time: hello bug #322493 MoveArea all the time: hello bug #323710
Since the focus of bug #323710 is the ability to only quartertile on the very \
screencorners, a special case will allow for both (on price of facing bug #322493, \
ie. the inability to tile under certain conditions)
Alternatives:
- base the area on strut sizes and mouse position relative to the window
- shift back the window against the movement direction until the relative \
mouseposition allows for tiling.
The MoveArea is however likely more correct anyway, since it matches the area where \
the window is tiled (though that's nitpicking as this is only about ratios)</pre> \
</blockquote>
<p>On August 26th, 2013, 2:42 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After quite some \
thinking I'm very unsure whether the ability to: 1) just use quick tiling in the \
corner 2) having a special handling for this case
is a valid usecase at all. I would even go so far and say that the corners should be \
excluded from the quick tiling/maximization logic as it's in both areas. Is the \
top left corner relevant for left edge or for top edge?
So unless someone can come up with very good arguments, I tend to -1 for this \
change.</pre> </blockquote>
<p>On August 26th, 2013, 4:16 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only argument i have \
is bug #323710 Declare it WONTFIX and i'll discard the RR - personally i \
don't care too much.
This patch wil hold for the bottom corners on most setups, though ;-P</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ping. should the bug \
become WONTFIX?</pre> <br />
<p>- Thomas</p>
<br />
<p>On August 19th, 2013, 5:15 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2013, 5:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323710">323710</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">simple patch, could go into 4.11/.1 but i'll not insist ;-)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/events.cpp <span style="color: grey">(9048118)</span></li>
<li>kwin/kcmkwin/kwinscreenedges/main.ui <span style="color: \
grey">(6985e8b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112161/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic