[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request 112392: Fix emission of mouseChanged when position changes between polling intervals
From: "Michael Chang" <seally.1186 () gmail ! com>
Date: 2013-08-30 23:31:25
Message-ID: 20130830233125.25180.70708 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112392/
-----------------------------------------------------------
Review request for kwin.
Description
-------
If Cursor::pos() is called and the mouse position or button mask changes, \
mousePolled() may not recognize the change and will fail to emit mouseChanged. This \
patch saved the last position and button mask seen by mousePolled, ensuring that \
mouseChanged will always be emitted if either has changed since the last poll.
This addresses bug 323979.
http://bugs.kde.org/show_bug.cgi?id=323979
Diffs
-----
kwin/cursor.h b1d9106
kwin/cursor.cpp 5e35a20
Diff: http://git.reviewboard.kde.org/r/112392/diff/
Testing
-------
The patch fixes the issue with the Zoom effect, which depends on mouseChanged.
Thanks,
Michael Chang
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112392/">http://git.reviewboard.kde.org/r/112392/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Michael Chang.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If Cursor::pos() is called and the mouse position or button mask \
changes, mousePolled() may not recognize the change and will fail to emit \
mouseChanged. This patch saved the last position and button mask seen by mousePolled, \
ensuring that mouseChanged will always be emitted if either has changed since the \
last poll.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch fixes the issue with the Zoom effect, which depends on \
mouseChanged.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323979">323979</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/cursor.h <span style="color: grey">(b1d9106)</span></li>
<li>kwin/cursor.cpp <span style="color: grey">(5e35a20)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112392/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic