From kwin Fri Aug 30 23:31:25 2013 From: "Michael Chang" Date: Fri, 30 Aug 2013 23:31:25 +0000 To: kwin Subject: Review Request 112392: Fix emission of mouseChanged when position changes between polling intervals Message-Id: <20130830233125.25180.70708 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=137790549808282 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6961961155180113191==" --===============6961961155180113191== Content-Type: multipart/alternative; boundary="===============3853258389910205295==" --===============3853258389910205295== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112392/ ----------------------------------------------------------- Review request for kwin. Description ------- If Cursor::pos() is called and the mouse position or button mask changes, mousePolled() may not recognize the change and will fail to emit mouseChanged. This patch saved the last position and button mask seen by mousePolled, ensuring that mouseChanged will always be emitted if either has changed since the last poll. This addresses bug 323979. http://bugs.kde.org/show_bug.cgi?id=323979 Diffs ----- kwin/cursor.h b1d9106 kwin/cursor.cpp 5e35a20 Diff: http://git.reviewboard.kde.org/r/112392/diff/ Testing ------- The patch fixes the issue with the Zoom effect, which depends on mouseChanged. Thanks, Michael Chang --===============3853258389910205295== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112392/

Review request for kwin.

By Michael Chang.

Description

If Cursor::pos() is called and the mouse position or button mask changes, mousePolled() may not recognize the change and will fail to emit mouseChanged. This patch saved the last position and button mask seen by mousePolled, ensuring that mouseChanged will always be emitted if either has changed since the last poll.

Testing

The patch fixes the issue with the Zoom effect, which depends on mouseChanged.

Bugs: 323979

Diffs

kwin/cursor.h (b1d9106)
kwin/cursor.cpp (5e35a20)

View Diff

--===============3853258389910205295==-- --===============6961961155180113191== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6961961155180113191==--