'Re: Review Request 109784: rebase measuring to nano resolution and fix initial padding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109784: rebase measuring to nano resolution and fix initial padding
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-03-30 17:40:14
Message-ID: 20130330174014.3060.70588 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109784/
-----------------------------------------------------------

(Updated March 30, 2013, 5:40 p.m.)

Review request for kwin, Martin Gräßlin and Ralf Jung.

Changes
-------

rebase to nano precision (requires Qt 4.8), thus fix conversion mess.
pro: most of the time i render < 0.66 ms =)

Description
-------

summarized

Diffs
-----

  kwin/composite.h ebaf7e7 
  kwin/composite.cpp ee885dc 
  kwin/options.h f61a66f 
  kwin/options.cpp 6abd3f0 
  kwin/scene.h 5d49c40 
  kwin/scene_opengl.h 409ec3d 
  kwin/scene_opengl.cpp 3343164 
  kwin/scene_xrender.h 4a93940 
  kwin/scene_xrender.cpp ab90815 

Diff: http://git.reviewboard.kde.org/r/109784/diff/

Testing
-------

it's math.
fpsinterval is n*vblankTime so this moves it 1ms past the last assumed tick before \
the wanted interval spot, so that we don't have to fear to miss it.

Assuming we paint every 3rd frame:

A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
                              ^ here (C1)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109784/">http://git.reviewboard.kde.org/r/109784/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 30, 2013, 5:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">rebase to nano precision (requires Qt 4.8), thus fix \
                conversion mess.
pro: most of the time i render &lt; 0.66 ms =)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it&#39;s math. fpsinterval is n*vblankTime so this moves it 1ms past the \
last assumed tick before the wanted interval spot, so that we don&#39;t have to fear \
to miss it.

Assuming we paint every 3rd frame:

A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
                              ^ here (C1)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.h <span style="color: grey">(ebaf7e7)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>

 <li>kwin/options.h <span style="color: grey">(f61a66f)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(6abd3f0)</span></li>

 <li>kwin/scene.h <span style="color: grey">(5d49c40)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(409ec3d)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(3343164)</span></li>

 <li>kwin/scene_xrender.h <span style="color: grey">(4a93940)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(ab90815)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109784/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 