[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109784: fix initial padding
From: "Ralf Jung" <post () ralfj ! de>
Date: 2013-03-29 9:38:07
Message-ID: 20130329093807.27746.67502 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109784/#review30057
-----------------------------------------------------------
If I understand the code properly, the fpsInterval has the unit "ms/1024", while \
m_timeSinceLastVBlank is just "ms". So some conversion would have to happen here. Or \
the times are all changed to be stored as "double", because this weird unit is \
horribly confusing, and the floating-point units are probably bored anyway as KWin \
has little floating pointer computations ;-)
- Ralf Jung
On March 28, 2013, 11:40 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109784/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 11:40 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> summarized
>
>
> Diffs
> -----
>
> kwin/composite.cpp ee885dc
>
> Diff: http://git.reviewboard.kde.org/r/109784/diff/
>
>
> Testing
> -------
>
> it's math.
> fpsinterval is n*vblankTime so this moves it 1ms past the last assumed tick before \
> the wanted interval spot, so that we don't have to fear to miss it.
> Assuming we paint every 3rd frame:
>
> A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
> ^ here (C1)
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109784/">http://git.reviewboard.kde.org/r/109784/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I understand the code \
properly, the fpsInterval has the unit "ms/1024", while \
m_timeSinceLastVBlank is just "ms". So some conversion would have to happen \
here. Or the times are all changed to be stored as "double", because this \
weird unit is horribly confusing, and the floating-point units are probably bored \
anyway as KWin has little floating pointer computations ;-)</pre> <br />
<p>- Ralf</p>
<br />
<p>On March 28th, 2013, 11:40 p.m. CET, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 11:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it's math. fpsinterval is n*vblankTime so this moves it 1ms past the \
last assumed tick before the wanted interval spot, so that we don't have to fear \
to miss it.
Assuming we paint every 3rd frame:
A 1 2 3 4 5 - B 1 2 3 4 5 - C 1 2 3 4 5 - A
^ here (C1)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(ee885dc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109784/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic