'Re: Review Request 108947: TabBox: Fix plasma theme workaround'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 108947: TabBox: Fix plasma theme workaround
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-03-28 23:31:22
Message-ID: 20130328233122.2228.22807 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108947/
-----------------------------------------------------------

(Updated March 28, 2013, 11:31 p.m.)

Review request for kwin, Martin Gräßlin, Sebastian Kügler, and Xuetian Weng.

Changes
-------

updated & rebased diff, less grumpy description ;-)

Summary (updated)
-----------------

TabBox: Fix plasma theme workaround

Description
-------

Needless to say that this should not have happened.

Neither the late push of the new air theme, nor the attempt to workaround the bug \
chain from Qt over KWindowSystem to Plasma::theme about not catching the compositing \
state.

This addresses bug 315064.
    http://bugs.kde.org/show_bug.cgi?id=315064

Diffs (updated)
-----

  kwin/tabbox/declarative.cpp 31e23a0 
  kwin/tabbox/qml/ShadowedSvgItem.qml 8bf76c8 

Diff: http://git.reviewboard.kde.org/r/108947/diff/

Testing (updated)
-------

Yes.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108947/">http://git.reviewboard.kde.org/r/108947/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin, Sebastian Kügler, and Xuetian \
Weng.</div> <div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 11:31 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">updated &amp; rebased diff, less grumpy description ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">TabBox: Fix plasma theme workaround</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Needless to say that this should not have happened.

Neither the late push of the new air theme, nor the attempt to workaround the bug \
chain from Qt over KWindowSystem to Plasma::theme about not catching the compositing \
state.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=315064">315064</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/declarative.cpp <span style="color: grey">(31e23a0)</span></li>

 <li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: \
grey">(8bf76c8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108947/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 