[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 107063: Add effect debug invokable, dbus interface and use it in AnimationEffect
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-28 19:32:26
Message-ID: 20130328193226.24317.70872 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107063/
-----------------------------------------------------------

(Updated March 28, 2013, 7:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Martin Gräßlin.


Description
-------

This is clearly no new feature but a develper tool. Can nicely go into 4.10 :-P

The parameter is thought to allow specific output / action.
Thanks to the metaObject invocation it's not required to run this const, ie. one \
could have an "effect" to measure random things and qdbus org.kde.kwin /Effects debug \
fullscreenCounter start qdbus org.kde.kwin /Effects debug  fullscreenCounter stop
qdbus org.kde.kwin /Effects debug  fullscreenCounter print

To show how many fullscreen repaints happened in a row in what timeframe etc.


Diffs
-----

  kwin/effects.h 6e922ff 
  kwin/effects.cpp 124a906 
  kwin/libkwineffects/anidata.cpp 3bb970f 
  kwin/libkwineffects/anidata_p.h 33d8c03 
  kwin/libkwineffects/kwinanimationeffect.h 2ffaa22 
  kwin/libkwineffects/kwinanimationeffect.cpp 0e126dc 
  kwin/org.kde.kwin.Effects.xml d060e8e 

Diff: http://git.reviewboard.kde.org/r/107063/diff/


Testing
-------

made a realy looooooong generic animation (w/o having even recompiled the effect) and \
tried

qdbus org.kde.kwin /Effects debug  generic_animations ""

while it was running, nicely printed me:

Animating window: [Deleted]
Animation: Opacity
     From: 1,1
       To: 0,0
  Started: 18:59:30
 Duration: 6000ms
   Passed: 969ms
 Applying: 3220444564

Granted: applying is currently an expert output, but one could implement "withTypes" \
to print the applying window types in a comma separated list or whatever.


Thanks,

Thomas Lübking


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107063/">http://git.reviewboard.kde.org/r/107063/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>


<p style="color: grey;"><i>Updated March 28, 2013, 7:32 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is clearly no new feature but a develper tool. Can nicely go into \
4.10 :-P

The parameter is thought to allow specific output / action.
Thanks to the metaObject invocation it&#39;s not required to run this const, ie. one \
could have an &quot;effect&quot; to measure random things and qdbus org.kde.kwin \
/Effects debug  fullscreenCounter start qdbus org.kde.kwin /Effects debug  \
fullscreenCounter stop qdbus org.kde.kwin /Effects debug  fullscreenCounter print

To show how many fullscreen repaints happened in a row in what timeframe etc.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">made a realy looooooong generic animation (w/o having even recompiled \
the effect) and tried

qdbus org.kde.kwin /Effects debug  generic_animations &quot;&quot;

while it was running, nicely printed me:

Animating window: [Deleted]
Animation: Opacity
     From: 1,1
       To: 0,0
  Started: 18:59:30
 Duration: 6000ms
   Passed: 969ms
 Applying: 3220444564

Granted: applying is currently an expert output, but one could implement \
&quot;withTypes&quot; to print the applying window types in a comma separated list or \
whatever. </pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects.h <span style="color: grey">(6e922ff)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(124a906)</span></li>

 <li>kwin/libkwineffects/anidata.cpp <span style="color: grey">(3bb970f)</span></li>

 <li>kwin/libkwineffects/anidata_p.h <span style="color: grey">(33d8c03)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(2ffaa22)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(0e126dc)</span></li>

 <li>kwin/org.kde.kwin.Effects.xml <span style="color: grey">(d060e8e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107063/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic