[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109484: do not release clients that where reparented somewhere else
From: "Commit Hook" <null () kde ! org>
Date: 2013-03-28 19:32:23
Message-ID: 20130328193223.24317.61549 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109484/
-----------------------------------------------------------
(Updated March 28, 2013, 7:32 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin and Martin Gräßlin.
Description
-------
this breaks re-embedding clients
See demo:
http://kde-apps.org/content/show.php?content=157471
If you set WORKAROUND_KWIN 0 this will fail on kwin but still operate correctly on \
every other WM (that I tested).
XReparentWindow causes an unmap of mapped clients, currently leading into \
releaseClient() This will (among other) eg. reparent the client to the root and this \
is (usually?) executed after the original XReparentWindow, so the client does not end \
up where it's supposed to be.
Diffs
-----
kwin/events.cpp b57e8ee
kwin/xcbutils.h 7a7add4
Diff: http://git.reviewboard.kde.org/r/109484/diff/
Testing
-------
Running for a couple of days and extensively tested with a re-embedding client. \
(Extended my testcode to a nested tiling semi-WM ;-) No issues spotted.
I can not suggest to play around with the release code much (ie. ensure you've \
nothing important else on screen) Simply omitting releaseClient() will keep you ghost \
clients (not only in the compositor) and releasing but uncertain omitting of the \
reparent to root will get your windows lost (no more activatable yakuake) and playing \
with the server grab or saveset lost me all windows on "kwin --replace &" =)
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109484/">http://git.reviewboard.kde.org/r/109484/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 7:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this breaks re-embedding clients
See demo:
http://kde-apps.org/content/show.php?content=157471
If you set WORKAROUND_KWIN 0 this will fail on kwin but still operate correctly on \
every other WM (that I tested).
XReparentWindow causes an unmap of mapped clients, currently leading into \
releaseClient() This will (among other) eg. reparent the client to the root and this \
is (usually?) executed after the original XReparentWindow, so the client does not end \
up where it's supposed to be.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Running for a couple of days and extensively tested with a re-embedding \
client. (Extended my testcode to a nested tiling semi-WM ;-) No issues spotted.
I can not suggest to play around with the release code much (ie. ensure you've \
nothing important else on screen) Simply omitting releaseClient() will keep you ghost \
clients (not only in the compositor) and releasing but uncertain omitting of the \
reparent to root will get your windows lost (no more activatable yakuake) and playing \
with the server grab or saveset lost me all windows on "kwin --replace \
&" =)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/events.cpp <span style="color: grey">(b57e8ee)</span></li>
<li>kwin/xcbutils.h <span style="color: grey">(7a7add4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109484/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic