'Re: Review Request 109679: consider shaded windows in checkWorkspaceGeometry'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109679: consider shaded windows in checkWorkspaceGeometry
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-28 19:32:14
Message-ID: 20130328193214.24072.71421 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109679/
-----------------------------------------------------------

(Updated March 28, 2013, 7:32 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

Description
-------

they act pretty much the same as unshaded windows, so i don't know
what prevented their inclusion but it seems gone now.

Even if there's an undetected glitch or so, that's still better than loosing them on an absent screen.

This addresses bug 268660.
    http://bugs.kde.org/show_bug.cgi?id=268660

Diffs
-----

  kwin/geometry.cpp 56255db 

Diff: http://git.reviewboard.kde.org/r/109679/diff/

Testing
-------

yes. not spotted issues so far (eg. on shrinking the resolution), but they occur on the remaining screen now.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109679/">http://git.reviewboard.kde.org/r/109679/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 7:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">they act pretty much \
the same as unshaded windows, so i don&#39;t know what prevented their inclusion but it seems \
gone now.

Even if there&#39;s an undetected glitch or so, that&#39;s still better than loosing them on an \
absent screen.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes. not spotted \
issues so far (eg. on shrinking the resolution), but they occur on the remaining screen \
now.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=268660">268660</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/geometry.cpp <span style="color: grey">(56255db)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109679/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 