From kwin Thu Mar 28 19:32:14 2013 From: "Commit Hook" Date: Thu, 28 Mar 2013 19:32:14 +0000 To: kwin Subject: Re: Review Request 109679: consider shaded windows in checkWorkspaceGeometry Message-Id: <20130328193214.24072.71421 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=136449915212809 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4814115613449730361==" --===============4814115613449730361== Content-Type: multipart/alternative; boundary="===============6326204933482303003==" --===============6326204933482303003== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109679/ ----------------------------------------------------------- (Updated March 28, 2013, 7:32 p.m.) Status ------ This change has been marked as submitted. Review request for kwin and Martin Gräßlin. Description ------- they act pretty much the same as unshaded windows, so i don't know what prevented their inclusion but it seems gone now. Even if there's an undetected glitch or so, that's still better than loosing them on an absent screen. This addresses bug 268660. http://bugs.kde.org/show_bug.cgi?id=268660 Diffs ----- kwin/geometry.cpp 56255db Diff: http://git.reviewboard.kde.org/r/109679/diff/ Testing ------- yes. not spotted issues so far (eg. on shrinking the resolution), but they occur on the remaining screen now. Thanks, Thomas Lübking --===============6326204933482303003== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109679/

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

By Thomas Lübking.

Updated March 28, 2013, 7:32 p.m.

Description

they act pretty much the same as unshaded windows, so i don't know
what prevented their inclusion but it seems gone now.

Even if there's an undetected glitch or so, that's still better than loosing them on an absent screen.

Testing

yes. not spotted issues so far (eg. on shrinking the resolution), but they occur on the remaining screen now.

Bugs: 268660

Diffs

kwin/geometry.cpp (56255db)

View Diff

--===============6326204933482303003==-- --===============4814115613449730361== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4814115613449730361==--