[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109706: Adding an activitiesChanged signal to Toplevel
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-03-25 15:42:59
Message-ID: 20130325154259.20021.93601 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109706/#review29862
-----------------------------------------------------------
Ship it!
kwin/client.cpp
<http://git.reviewboard.kde.org/r/109706/#comment22195>
past the blocking check (otherwise you'd get this despite the window is not \
visually altered, could be nasty on effect invocation and just produce overherad \
otherwise)
And then where is the bug id? ;-P
- Thomas Lübking
On March 25, 2013, 2:22 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109706/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 2:22 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Adding an activitiesChanged signal to Toplevel
>
> Only emitted from Client.
>
> Targetting for 4.10 as this has been requested and can be considered a bugfix.
>
>
> Diffs
> -----
>
> kwin/client.cpp a694cdd426826732f0c4658b30433a70a4e0aafd
> kwin/toplevel.h 371490891e7c2a62d12e0539b7f2be8f565c0420
>
> Diff: http://git.reviewboard.kde.org/r/109706/diff/
>
>
> Testing
> -------
>
> compiled on master, will be tested on the model work
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109706/">http://git.reviewboard.kde.org/r/109706/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109706/diff/1/?file=121474#file121474line1570" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::blockActivityUpdates(bool b)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1570</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">emit</span> <span class="n">activitiesChanged</span><span \
class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">past the \
blocking check (otherwise you'd get this despite the window is not visually \
altered, could be nasty on effect invocation and just produce overherad \
otherwise)</pre> </div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And then where is the \
bug id? ;-P</pre>
<p>- Thomas</p>
<br />
<p>On March 25th, 2013, 2:22 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding an activitiesChanged signal to Toplevel
Only emitted from Client.
Targetting for 4.10 as this has been requested and can be considered a bugfix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled on master, will be tested on the model work</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: \
grey">(a694cdd426826732f0c4658b30433a70a4e0aafd)</span></li>
<li>kwin/toplevel.h <span style="color: \
grey">(371490891e7c2a62d12e0539b7f2be8f565c0420)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109706/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic