'Re: Review Request 109212: export AnimationEffect::set and ::cancel to scripting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109212: export AnimationEffect::set and ::cancel to scripting
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-03-22 19:53:07
Message-ID: 20130322195307.7179.11202 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109212/
-----------------------------------------------------------

(Updated March 22, 2013, 7:53 p.m.)

Review request for kwin and Martin Gräßlin.

Changes
-------

* anon enum
* s/a/type; s/A/Type
* doxygen (or whatever format that is, it's not build with kwin, is it?)

Description
-------

requires https://git.reviewboard.kde.org/r/109211/

Also harmonize script parsing - any combination of animationarray and global \
animation setting that results in a valid animation is possible using the global \
settings as default on the array values.

Diffs (updated)
-----

  kwin/scripting/documentation-effect-global.xml d08d517 
  kwin/scripting/scriptedeffect.h 44189a7 
  kwin/scripting/scriptedeffect.cpp c04e22e 

Diff: http://git.reviewboard.kde.org/r/109212/diff/

Testing
-------

see https://git.reviewboard.kde.org/r/109211/

File Attachments
----------------

Transcend script
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/28/kwin4_effect_transcend.kwinscript

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109212/">http://git.reviewboard.kde.org/r/109212/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 22, 2013, 7:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* anon enum
* s/a/type; s/A/Type
* doxygen (or whatever format that is, it&#39;s not build with kwin, is it?)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">requires https://git.reviewboard.kde.org/r/109211/

Also harmonize script parsing - any combination of animationarray and global \
animation setting that results in a valid animation is possible using the global \
settings as default on the array values. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://git.reviewboard.kde.org/r/109211/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripting/documentation-effect-global.xml <span style="color: \
grey">(d08d517)</span></li>

 <li>kwin/scripting/scriptedeffect.h <span style="color: grey">(44189a7)</span></li>

 <li>kwin/scripting/scriptedeffect.cpp <span style="color: \
grey">(c04e22e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109212/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/28/kwin4_effect_transcend.kwinscript">Transcend \
script</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 