[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109212: export AnimationEffect::set and ::cancel to scripting
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-03-22 14:17:44
Message-ID: 20130322141744.2818.39253 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 22, 2013, 12:07 p.m., Martin Gräßlin wrote:
> > kwin/scripting/scriptedeffect.cpp, line 96
> > <http://git.reviewboard.kde.org/r/109212/diff/1/?file=116256#file116256line96>
> >
> > In the context of JavaScript bindings I don't really like the name "var". Also A \
> > is a little bit generic ;-)
You mean like the present "AnimationEffect::Attribute a;" struct parameter ;-P
Gonna relabel both as "Type" / "type"
"Var" describes the enum, but it can actually be just anonymous.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109212/#review29701
-----------------------------------------------------------
On Feb. 28, 2013, 7:04 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109212/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 7:04 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> requires https://git.reviewboard.kde.org/r/109211/
>
> Also harmonize script parsing - any combination of animationarray and global \
> animation setting that results in a valid animation is possible using the global \
> settings as default on the array values.
>
> Diffs
> -----
>
> kwin/scripting/scriptedeffect.h 63eb66c
> kwin/scripting/scriptedeffect.cpp 83650f1
>
> Diff: http://git.reviewboard.kde.org/r/109212/diff/
>
>
> Testing
> -------
>
> see https://git.reviewboard.kde.org/r/109211/
>
>
> File Attachments
> ----------------
>
> Transcend script
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/28/kwin4_effect_transcend.kwinscript
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109212/">http://git.reviewboard.kde.org/r/109212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2013, 12:07 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109212/diff/1/?file=116256#file116256line96" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scripting/scriptedeffect.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QScriptValue kwinScriptGlobalShortcut(QScriptContext *context, QScriptEngine \
*engine)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">96</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">enum</span> <span class="n">Var</span> <span class="p">{</span> <span \
class="n">A</span> <span class="o">=</span> <span class="mi">1</span><span \
class="o"><<</span><span class="mi">0</span><span class="p">,</span> <span \
class="n">Curve</span> <span class="o">=</span> <span class="mi">1</span><span \
class="o"><<</span><span class="mi">1</span><span class="p">,</span> <span \
class="n">Delay</span> <span class="o">=</span> <span class="mi">1</span><span \
class="o"><<</span><span class="mi">2</span><span class="p">,</span> <span \
class="n">Duration</span> <span class="o">=</span> <span class="mi">1</span><span \
class="o"><<</span><span class="mi">3</span> <span \
class="p">};</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the context of \
JavaScript bindings I don't really like the name "var". Also A is a \
little bit generic ;-)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You mean \
like the present "AnimationEffect::Attribute a;" struct parameter ;-P Gonna \
relabel both as "Type" / "type"
"Var" describes the enum, but it can actually be just anonymous.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On February 28th, 2013, 7:04 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2013, 7:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">requires https://git.reviewboard.kde.org/r/109211/
Also harmonize script parsing - any combination of animationarray and global \
animation setting that results in a valid animation is possible using the global \
settings as default on the array values. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://git.reviewboard.kde.org/r/109211/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scripting/scriptedeffect.h <span style="color: grey">(63eb66c)</span></li>
<li>kwin/scripting/scriptedeffect.cpp <span style="color: \
grey">(83650f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109212/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/28/kwin4_effect_transcend.kwinscript">Transcend \
script</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic