[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Support for new decoration border sizes BorderBottom and BorderNone
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-10 7:36:50
Message-ID: 20130110073650.19968.91978 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108164/
-----------------------------------------------------------
(Updated Jan. 10, 2013, 7:36 a.m.)
Review request for kwin and Hugo Pereira Da Costa.
Changes
-------
renamed to "BorderNoSides"
Description (updated)
-------
Support for new decoration border sizes BorderBottom and BorderNone
BorderBottom is what is known from Oxygen as "No Side Borders". The name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.
The new enums are added to KDecoration and the KCM so that all decos can
make use of it.
Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.
Diffs (updated)
-----
kwin/clients/aurorae/src/decorationoptions.h 4f469fec16f1045ca75101b497f3=
1b04a55e48d8 =
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml f868fe79=
e70dc217d375a4515e323c5fe5a795f9 =
kwin/kcmkwin/kwindecoration/configdialog.h f07befc808c15e902a91b71b9f1ae3=
0b72831573 =
kwin/kcmkwin/kwindecoration/configdialog.cpp a047c44d0e575a928a69f2dc3a32=
5fbcfb444cfa =
kwin/kcmkwin/kwindecoration/kwindecoration.cpp 8e66099ff32a41ca27ccb038af=
e3422768e9491e =
kwin/libkdecorations/kdecoration.h e37fd6275bfe2f072c44be3fdc55fe56d40364=
81 =
Diff: http://git.reviewboard.kde.org/r/108164/diff/
Testing
-------
Screenshots
-----------
Plastik with no side border
http://git.reviewboard.kde.org/r/108164/s/971/
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108164/">http://git.reviewboard.kde.org/r/108164/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 7:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">renamed to "BorderNoSides"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support for new decoration border sizes BorderBottom and BorderNone
BorderBottom is what is known from Oxygen as "No Side Borders". The name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.
The new enums are added to KDecoration and the KCM so that all decos can
make use of it.
Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/decorationoptions.h <span style="color: \
grey">(4f469fec16f1045ca75101b497f31b04a55e48d8)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(f868fe79e70dc217d375a4515e323c5fe5a795f9)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.h <span style="color: \
grey">(f07befc808c15e902a91b71b9f1ae30b72831573)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.cpp <span style="color: \
grey">(a047c44d0e575a928a69f2dc3a325fbcfb444cfa)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(8e66099ff32a41ca27ccb038afe3422768e9491e)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(e37fd6275bfe2f072c44be3fdc55fe56d4036481)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108164/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108164/s/971/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/04/plastik-no-side-border_400x100.png" \
style="border: 1px black solid;" alt="Plastik with no side border" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic