[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Support for new decoration border sizes BorderBottom and BorderNone
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-05 6:00:20
Message-ID: 20130105060020.7793.60979 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 4, 2013, 8:06 p.m., Thomas L=C3=BCbking wrote:
> > I called it "Base" border (vertical titlebar in mind) but that's not id=
eal either - try "ConterTitle" ;-)
> =
> Hugo Pereira Da Costa wrote:
> The original idea with NoSideBorder (or BorderNoSides), was the "Left=
/Right" primary meaning of "sides", in contrast to NoBorder (or BorderNone)=
, although I acknowledge that Top and Bottom are also "sides".
> =
> I still prefer "BorderNoSides" to "BorderBottom", but that might be a=
French bias ... (meaning, to me "BorderNoSides" did make sense when it was=
originally suggested by Zarin)
> =
> Richard Stockton wrote:
> To this USA person, "BorderBottomOnly" seems best. "BorderNoSides" is=
also quite good. But you must first envision all the borders (and then 'su=
btact' the sides, leaving only the bottom). "BorderBottom" is 3rd: less goo=
d, because it invokes visions of "borders" on the back side of your pants.
> =
> "BaseBorder" is bad in US English, because we think of layers... we n=
ever speak of the "base" of the screen, only the bottom of the screen. (All=
your base are belong to us?) And CounterTitle" seems the worst of these ch=
oices, I would have would have had no idea about the meaning of this word- =
without already being in _this_ discussion, talking about this specific Win=
dow decoration issue.
thanks for the feedback. I think I will go for "BorderNoSides" to also cove=
r the case that title is on left/right.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108164/#review24694
-----------------------------------------------------------
On Jan. 4, 2013, 1:10 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108164/
> -----------------------------------------------------------
> =
> (Updated Jan. 4, 2013, 1:10 p.m.)
> =
> =
> Review request for kwin and Hugo Pereira Da Costa.
> =
> =
> Description
> -------
> =
> Support for new decoration border sizes BorderBottom and BorderNone
> =
> BorderBottom is what is known from Oxygen as "No Side Borders". The name
> should indicate that there is only a border at the bottom. BorderNone is
> a mode with no borders at all.
> =
> The new enums are added to KDecoration and the KCM so that all decos can
> make use of it.
> =
> Aurorae is adjusted to support the new sizes for QML themes (it breaks
> the old svg based themes) and Plastik makes use of it, by rendering a
> one-pixel border around the window, which illustrates that it's still up
> to the decoration to decide how to make use of the setting.
> =
> @Hugo: in case you want to port Oxygen to the feature: due to ABI compati=
bility the BorderBottom and BorderNone are added to the end of the list, wh=
ile in Oxygen they are listed as first elements (which make much more sense=
).
> =
> @All: a better name for BorderBottom would be nice :-)
> =
> =
> Diffs
> -----
> =
> kwin/clients/aurorae/src/decorationoptions.h 4f469fec16f1045ca75101b497=
f31b04a55e48d8 =
> kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml c6b304=
2bafbf4ec1afea5f083f2702955c739ffc =
> kwin/kcmkwin/kwindecoration/configdialog.h f07befc808c15e902a91b71b9f1a=
e30b72831573 =
> kwin/kcmkwin/kwindecoration/configdialog.cpp a047c44d0e575a928a69f2dc3a=
325fbcfb444cfa =
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp 8e66099ff32a41ca27ccb038=
afe3422768e9491e =
> kwin/libkdecorations/kdecoration.h e37fd6275bfe2f072c44be3fdc55fe56d403=
6481 =
> =
> Diff: http://git.reviewboard.kde.org/r/108164/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Plastik with no side border
> http://git.reviewboard.kde.org/r/108164/s/971/
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108164/">http://git.reviewboard.kde.org/r/108164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 4th, 2013, 8:06 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I called it "Base" border (vertical titlebar in mind) but \
that's not ideal either - try "ConterTitle" ;-)</pre> </blockquote>
<p>On January 4th, 2013, 8:50 p.m., <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The original idea with \
NoSideBorder (or BorderNoSides), was the "Left/Right" primary meaning of \
"sides", in contrast to NoBorder (or BorderNone), although I acknowledge \
that Top and Bottom are also "sides".
I still prefer "BorderNoSides" to "BorderBottom", but that might \
be a French bias ... (meaning, to me "BorderNoSides" did make sense when it \
was originally suggested by Zarin)</pre> </blockquote>
<p>On January 5th, 2013, 12:19 a.m., <b>Richard Stockton</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To this USA person, \
"BorderBottomOnly" seems best. "BorderNoSides" is also quite \
good. But you must first envision all the borders (and then 'subtact' the \
sides, leaving only the bottom). "BorderBottom" is 3rd: less good, because \
it invokes visions of "borders" on the back side of your pants.
"BaseBorder" is bad in US English, because we think of layers... we never \
speak of the "base" of the screen, only the bottom of the screen. (All your \
base are belong to us?) And CounterTitle" seems the worst of these choices, I \
would have would have had no idea about the meaning of this word- without already \
being in _this_ discussion, talking about this specific Window decoration issue. \
</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks for the feedback. \
I think I will go for "BorderNoSides" to also cover the case that title is \
on left/right.</pre> <br />
<p>- Martin</p>
<br />
<p>On January 4th, 2013, 1:10 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 1:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support for new decoration border sizes BorderBottom and BorderNone
BorderBottom is what is known from Oxygen as "No Side Borders". The name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.
The new enums are added to KDecoration and the KCM so that all decos can
make use of it.
Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.
@Hugo: in case you want to port Oxygen to the feature: due to ABI compatibility the \
BorderBottom and BorderNone are added to the end of the list, while in Oxygen they \
are listed as first elements (which make much more sense).
@All: a better name for BorderBottom would be nice :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/decorationoptions.h <span style="color: \
grey">(4f469fec16f1045ca75101b497f31b04a55e48d8)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(c6b3042bafbf4ec1afea5f083f2702955c739ffc)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.h <span style="color: \
grey">(f07befc808c15e902a91b71b9f1ae30b72831573)</span></li>
<li>kwin/kcmkwin/kwindecoration/configdialog.cpp <span style="color: \
grey">(a047c44d0e575a928a69f2dc3a325fbcfb444cfa)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(8e66099ff32a41ca27ccb038afe3422768e9491e)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(e37fd6275bfe2f072c44be3fdc55fe56d4036481)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108164/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108164/s/971/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/04/plastik-no-side-border_400x100.png" \
style="border: 1px black solid;" alt="Plastik with no side border" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic