[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Don't calculate "nominalCursorSize"
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2013-01-02 17:28:20
Message-ID: 20130102172820.28817.68650 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 2, 2013, 8:47 a.m., Martin Gräßlin wrote:
> > fine for me. Sorry for the late reply - seems like I still have a \
> > vacations induced backlog.
>
> Thomas Lübking wrote:
> I was actually more waiting for a reply on "what was it meant for anyway" \
> from Sebastian. Life experience however says: cnp autopilot ;-)
>
Ähh .... for the records: it's long time in ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107452/#review24411
-----------------------------------------------------------
On Nov. 24, 2012, 6:04 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107452/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2012, 6:04 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Sebastian Sauer.
>
>
> Description
> -------
>
> See bug. The function restricts the available sizes to power-of-two, \
> getting us the wrong size for the texture. Since the kcm is apparently \
> "broken" (the preview sizes) and I've absolutely no idea what this should \
> be good for at all and in our case and since it fixes the issue, i \
> propose to drop it.
>
> This addresses bug 310497.
> http://bugs.kde.org/show_bug.cgi?id=310497
>
>
> Diffs
> -----
>
> kwin/effects/zoom/zoom.cpp da89751
>
> Diff: http://git.reviewboard.kde.org/r/107452/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107452/">http://git.reviewboard.kde.org/r/107452/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On January 2nd, 2013, 8:47 \
a.m., <b>Martin Gräßlin</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fine for me. \
Sorry for the late reply - seems like I still have a vacations induced \
backlog.</pre> </blockquote>
<p>On January 2nd, 2013, 2:56 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was actually more waiting for a reply on "what was it \
meant for anyway" from Sebastian. Life experience however says: cnp \
autopilot ;-) </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ähh .... for \
the records: it's long time in ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On November 24th, 2012, 6:04 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Sebastian Sauer.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2012, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See bug. The function restricts the available sizes to \
power-of-two, getting us the wrong size for the texture. Since the kcm is \
apparently "broken" (the preview sizes) and I've absolutely \
no idea what this should be good for at all and in our case and since it \
fixes the issue, i propose to drop it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310497">310497</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/zoom/zoom.cpp <span style="color: \
grey">(da89751)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107452/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic