From kwin Wed Jan 02 17:28:20 2013 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Wed, 02 Jan 2013 17:28:20 +0000 To: kwin Subject: Re: Review Request: Don't calculate "nominalCursorSize" Message-Id: <20130102172820.28817.68650 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135714771129800 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8569359056293675106==" --===============8569359056293675106== Content-Type: multipart/alternative; boundary="===============2774866527854693466==" --===============2774866527854693466== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 2, 2013, 8:47 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > fine for me. Sorry for the late reply - seems like I still have a vacat= ions induced backlog. > = > Thomas L=C3=BCbking wrote: > I was actually more waiting for a reply on "what was it meant for any= way" from Sebastian. > Life experience however says: cnp autopilot ;-) > =C3=84hh .... for the records: it's long time in ;-) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107452/#review24411 ----------------------------------------------------------- On Nov. 24, 2012, 6:04 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107452/ > ----------------------------------------------------------- > = > (Updated Nov. 24, 2012, 6:04 p.m.) > = > = > Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Sebastian Sauer. > = > = > Description > ------- > = > See bug. The function restricts the available sizes to power-of-two, gett= ing us the wrong size for the texture. > Since the kcm is apparently "broken" (the preview sizes) and I've absolut= ely no idea what this should be good for at all and in our case and since i= t fixes the issue, i propose to drop it. > = > = > This addresses bug 310497. > http://bugs.kde.org/show_bug.cgi?id=3D310497 > = > = > Diffs > ----- > = > kwin/effects/zoom/zoom.cpp da89751 = > = > Diff: http://git.reviewboard.kde.org/r/107452/diff/ > = > = > Testing > ------- > = > yes > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============2774866527854693466== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107452/

On January 2nd, 2013, 8:47 a.m., Martin Gr= =C3=A4=C3=9Flin wrote:

fine for =
me. Sorry for the late reply - seems like I still have a vacations induced =
backlog.

On January 2nd, 2013, 2:56 p.m., Thomas L=C3=BCbking wrote:

I was act=
ually more waiting for a reply on "what was it meant for anyway" =
from Sebastian.
Life experience however says: cnp autopilot ;-)

=C3=84hh ..=
.. for the records: it's long time in ;-)

- Thomas


On November 24th, 2012, 6:04 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Sebastian Sauer.=
By Thomas L=C3=BCbking.

Updated Nov. 24, 2012, 6:04 p.m.

Descripti= on 

See bug. The function restricts the available sizes to power=
-of-two, getting us the wrong size for the texture.
Since the kcm is apparently "broken" (the preview sizes) and I=
9;ve absolutely no idea what this should be good for at all and in our case=
 and since it fixes the issue, i propose to drop it.

Testing <= /h1> 
yes
Bugs: 310497

Diffs=

  • kwin/effects/zoom/zoom.cpp (da89751)

View Diff
--===============2774866527854693466==-- --===============8569359056293675106== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8569359056293675106==--