'Re: Review Request: use synthetic configure notifications when needed'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: use synthetic configure notifications when needed
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-30 16:46:14
Message-ID: 20121230164614.21980.79764 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108013/
-----------------------------------------------------------

(Updated Dec. 30, 2012, 4:46 p.m.)

Review request for kwin and Martin Gräßlin.

Description
-------

The notifications on resizes are required or gtk+ (and gtk3 as well) will either not resize or lag \
internal updates etc. Qt is not affected, TK needs the notification when leaving the move.

On the other side it's not required at all to send them when just moving w/o actually XMoveResize  the \
window (apparently TK gives a shit on the geometry in the notification, but only wants a trigger to then \
look up the position via Xlib or whatever it will do there) and i'm willing to risk to say: also not when \
moving otherwise (but only once when leaving the move)

This addresses bug 312346.
    http://bugs.kde.org/show_bug.cgi?id=312346

Diffs
-----

  kwin/geometry.cpp 6a7ded4 

Diff: http://git.reviewboard.kde.org/r/108013/diff/

Testing (updated)
-------

I tested a bunch of clients, like XMaxima (TK) gtk[3]-demo, chromium & google earth, wine/notepad, some \
sdl games, mupdf (probably no toolkit), xterm and gvim (aside kwrite, qupzilla, dolphin and whatever else \
i've open anyway) but would llike to know and test some extra smart client actually reacting on move \
events (by altering it's color or moving around some transient or so) - just that i don't know one :-(

Tested FF (Xul) and LibreOffice (UNO)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108013/">http://git.reviewboard.kde.org/r/108013/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2012, 4:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The notifications on resizes are required or \
gtk+ (and gtk3 as well) will either not resize or lag internal updates etc. Qt is not affected, TK needs \
the notification when leaving the move.

On the other side it&#39;s not required at all to send them when just moving w/o actually XMoveResize  \
the window (apparently TK gives a shit on the geometry in the notification, but only wants a trigger to \
then look up the position via Xlib or whatever it will do there) and i&#39;m willing to risk to say: also \
not when moving otherwise (but only once when leaving the move)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested a bunch of clients, like XMaxima \
(TK) gtk[3]-demo, chromium &amp; google earth, wine/notepad, some sdl games, mupdf (probably no toolkit), \
xterm and gvim (aside kwrite, qupzilla, dolphin and whatever else i&#39;ve open anyway) but would llike \
to know and test some extra smart client actually reacting on move events (by altering it&#39;s color or \
moving around some transient or so) - just that i don&#39;t know one :-(

Tested FF (Xul) and LibreOffice (UNO)</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=312346">312346</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/geometry.cpp <span style="color: grey">(6a7ded4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108013/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 