From kwin Sun Dec 30 16:46:14 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sun, 30 Dec 2012 16:46:14 +0000 To: kwin Subject: Re: Review Request: use synthetic configure notifications when needed Message-Id: <20121230164614.21980.79764 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135688598331260 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1162153729535558293==" --===============1162153729535558293== Content-Type: multipart/alternative; boundary="===============3229808783309840479==" --===============3229808783309840479== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108013/ ----------------------------------------------------------- (Updated Dec. 30, 2012, 4:46 p.m.) Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Description ------- The notifications on resizes are required or gtk+ (and gtk3 as well) will e= ither not resize or lag internal updates etc. Qt is not affected, TK needs the notification when leaving the move. On the other side it's not required at all to send them when just moving w/= o actually XMoveResize the window (apparently TK gives a shit on the geome= try in the notification, but only wants a trigger to then look up the posit= ion via Xlib or whatever it will do there) and i'm willing to risk to say: = also not when moving otherwise (but only once when leaving the move) This addresses bug 312346. http://bugs.kde.org/show_bug.cgi?id=3D312346 Diffs ----- kwin/geometry.cpp 6a7ded4 = Diff: http://git.reviewboard.kde.org/r/108013/diff/ Testing (updated) ------- I tested a bunch of clients, like XMaxima (TK) gtk[3]-demo, chromium & goog= le earth, wine/notepad, some sdl games, mupdf (probably no toolkit), xterm = and gvim (aside kwrite, qupzilla, dolphin and whatever else i've open anywa= y) but would llike to know and test some extra smart client actually reacti= ng on move events (by altering it's color or moving around some transient o= r so) - just that i don't know one :-( Tested FF (Xul) and LibreOffice (UNO) Thanks, Thomas L=C3=BCbking --===============3229808783309840479== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108013/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated Dec. 30, 2012, 4:46 p.m.

Descripti= on

The notifications on resizes are required or gtk+ (and gtk3 =
as well) will either not resize or lag internal updates etc.
Qt is not affected, TK needs the notification when leaving the move.

On the other side it's not required at all to send them when just movin=
g w/o actually XMoveResize  the window (apparently TK gives a shit on the g=
eometry in the notification, but only wants a trigger to then look up the p=
osition via Xlib or whatever it will do there) and i'm willing to risk =
to say: also not when moving otherwise (but only once when leaving the move=
)

Testing (= updated)

I tested a bunch of clients, like XMaxima (TK) gtk[3]-demo, =
chromium & google earth, wine/notepad, some sdl games, mupdf (probably =
no toolkit), xterm and gvim (aside kwrite, qupzilla, dolphin and whatever e=
lse i've open anyway) but would llike to know and test some extra smart=
 client actually reacting on move events (by altering it's color or mov=
ing around some transient or so) - just that i don't know one :-(

Tested FF (Xul) and LibreOffice (UNO)

Bugs: 312346

Diffs=

kwin/geometry.cpp (6a7ded4)

--===============3229808783309840479==-- --===============1162153729535558293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1162153729535558293==--