[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: finish & sync screenshot paint before calling ksnapshot
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-28 15:55:23
Message-ID: 20121228155523.4845.47870 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 28, 2012, 3:17 p.m., Martin Gräßlin wrote:
> > completely unrelated comment to the patch: we need to think about a way to pass \
> > the screenshot to KSnapshot for Qt 5 as we cannot get a QPixmap from an X11 \
> > Pixmap any more.
/tmp/hash.png, shm or xputimage.
the absence of the native graphicssystem is gonna get us much more fun (current \
legacy decos, laptop happily segfaulted the x11 server on the raster engine here; \
xrender backend and raster decos are unusably slooow - so either we scratch that \
backend or figure a more general solution; painting some elements on xrender, we'll \
have to cache them in persistent Pictures, etc.)
reg. the deco and because of wayland: i think we'll need a much more abstracted API \
anyway, because we're unlikley gonna "reparent" into some QWidget on wayland and \
emulating this (for input and as graphics carrier) would just be restricting. Ideally \
i'd say we obtain some images from the deco, convert them to either texture or \
Picture and let the deco "paint" the result (DecoPainter::drawTile(sx,sy,...) but for \
eg. oxygen on xrender we either keep those dead slow "create a huge gradient image, \
upload it and paint it" or have DecoPainter::drawGradient() resolving to OpenGL & \
xrender directly (while i've no idea about fglrx and xrender gradients - used to be \
instant fail... couple of years ago ;-)
Benefit would be a huuuge performance gain by bypasing all the convert/upload stuff, \
but i'm not sure how to get that "compatible" with QML...
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107981/#review24110
-----------------------------------------------------------
On Dec. 28, 2012, 2:19 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107981/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2012, 2:19 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> ... and i'm betting your ... little finger ... that this is gonna fix it ;-)
>
>
> This addresses bug 312209.
> http://bugs.kde.org/show_bug.cgi?id=312209
>
>
> Diffs
> -----
>
> kwin/effects/screenshot/screenshot.cpp 4254c37
>
> Diff: http://git.reviewboard.kde.org/r/107981/diff/
>
>
> Testing
> -------
>
> nope.
> But 1. is there absolutely no guarantee to deconstruct sth. on the stack right when \
> the context ends (thus whenever you want to use sth. just painted, rather ::end() \
> explicitly) and 2. should we ensure that everything is actually done.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107981/">http://git.reviewboard.kde.org/r/107981/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 28th, 2012, 3:17 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">completely unrelated comment to the patch: we need to think about a way \
to pass the screenshot to KSnapshot for Qt 5 as we cannot get a QPixmap from an X11 \
Pixmap any more.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/tmp/hash.png, shm or \
xputimage.
the absence of the native graphicssystem is gonna get us much more fun (current \
legacy decos, laptop happily segfaulted the x11 server on the raster engine here; \
xrender backend and raster decos are unusably slooow - so either we scratch that \
backend or figure a more general solution; painting some elements on xrender, \
we'll have to cache them in persistent Pictures, etc.)
reg. the deco and because of wayland: i think we'll need a much more abstracted \
API anyway, because we're unlikley gonna "reparent" into some QWidget \
on wayland and emulating this (for input and as graphics carrier) would just be \
restricting. Ideally i'd say we obtain some images from the deco, convert them to \
either texture or Picture and let the deco "paint" the result \
(DecoPainter::drawTile(sx,sy,...) but for eg. oxygen on xrender we either keep those \
dead slow "create a huge gradient image, upload it and paint it" or have \
DecoPainter::drawGradient() resolving to OpenGL & xrender directly (while \
i've no idea about fglrx and xrender gradients - used to be instant fail... \
couple of years ago ;-)
Benefit would be a huuuge performance gain by bypasing all the convert/upload stuff, \
but i'm not sure how to get that "compatible" with QML...</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 28th, 2012, 2:19 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 2:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">... and i'm betting your ... little finger ... that this is gonna \
fix it ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">nope. But 1. is there absolutely no guarantee to deconstruct sth. on the \
stack right when the context ends (thus whenever you want to use sth. just painted, \
rather ::end() explicitly) and 2. should we ensure that everything is actually \
done.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312209">312209</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(4254c37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107981/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic