'Re: Review Request: finish & sync screenshot paint before calling ksnapshot'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: finish & sync screenshot paint before calling ksnapshot
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-12-28 15:17:54
Message-ID: 20121228151754.1175.65157 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107981/#review24110
-----------------------------------------------------------

completely unrelated comment to the patch: we need to think about a way to pass the \
screenshot to KSnapshot for Qt 5 as we cannot get a QPixmap from an X11 Pixmap any \
more.

- Martin Gräßlin

On Dec. 28, 2012, 2:19 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107981/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 2:19 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> ... and i'm betting your ... little finger ... that this is gonna fix it ;-)
> 
> 
> This addresses bug 312209.
> http://bugs.kde.org/show_bug.cgi?id=312209
> 
> 
> Diffs
> -----
> 
> kwin/effects/screenshot/screenshot.cpp 4254c37 
> 
> Diff: http://git.reviewboard.kde.org/r/107981/diff/
> 
> 
> Testing
> -------
> 
> nope.
> But 1. is there absolutely no guarantee to deconstruct sth. on the stack right when \
> the context ends (thus whenever you want to use sth. just painted, rather ::end() \
> explicitly) and 2. should we ensure that everything is actually done. 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107981/">http://git.reviewboard.kde.org/r/107981/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">completely unrelated \
comment to the patch: we need to think about a way to pass the screenshot to \
KSnapshot for Qt 5 as we cannot get a QPixmap from an X11 Pixmap any more.</pre>  <br \
/>

<p>- Martin</p>

<br />
<p>On December 28th, 2012, 2:19 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2012, 2:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">... and i&#39;m betting your ... little finger ... that this is gonna \
fix it ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">nope. But 1. is there absolutely no guarantee to deconstruct sth. on the \
stack right when the context ends (thus whenever you want to use sth. just painted, \
rather ::end() explicitly) and 2. should we ensure that everything is actually \
done.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=312209">312209</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(4254c37)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107981/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 