'Re: Review Request: Rewrite KillWindow on top of XCB'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Rewrite KillWindow on top of XCB
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-27 14:59:19
Message-ID: 20121227145919.23848.63011 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107945/#review24057
-----------------------------------------------------------

Wasn't there some review to remove the slot (or was it just the dbus interf=
ace?)

- Thomas L=C3=BCbking

On Dec. 27, 2012, 2:03 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107945/
> -----------------------------------------------------------
> =

> (Updated Dec. 27, 2012, 2:03 p.m.)
> =

> =

> Review request for kwin and Fredrik H=C3=B6glund.
> =

> =

> Description
> -------
> =

> Rewrite KillWindow on top of XCB
> =

> The code is rewritten in a way to replace the local event loop with event
> filtering done in the normal way through events.cpp. Therefore instead of
> creating a KillWindow whenever it's needed, there is one available in
> Workspace which will be reused on next invocation.
> =

> The responsible events are passed from events.cpp to KillWindow for
> processing.
> =

> In order to port the keycode to symbol to XCB, KWin now finds
> xcb_keysyms and links it.
> =

> Currently there is one regression: the standard icon is used instead of
> the user styled one.
> =

> =

> Diffs
> -----
> =

>   cmake/modules/FindXCB.cmake 7850c6831858ecd9f9d798d7a163115b2f0eeac9 =

>   kwin/CMakeLists.txt 62e9964a60783456dd11958f7a105e9d4df110c2 =

>   kwin/events.cpp 281f9e708d4488c504b8fc5eba3de5757a59c915 =

>   kwin/killwindow.h 585331ade43c052ff1e7de0e4976fb0fae54d7b0 =

>   kwin/killwindow.cpp 57e15e525a4428b80f5bc3c28d2934d7a4caa401 =

>   kwin/useractions.cpp 3617d2938cfd2483a0fb7591ffbce102db482b61 =

>   kwin/workspace.h 84163347d346d6381a4d825b560d30f04787e3c2 =

> =

> Diff: http://git.reviewboard.kde.org/r/107945/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107945/">http://git.reviewboard.kde.org/r/107945/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wasn&#39;t there some \
review to remove the slot (or was it just the dbus interface?)</pre>  <br />

<p>- Thomas</p>

<br />
<p>On December 27th, 2012, 2:03 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2012, 2:03 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rewrite KillWindow on top of XCB

The code is rewritten in a way to replace the local event loop with event
filtering done in the normal way through events.cpp. Therefore instead of
creating a KillWindow whenever it&#39;s needed, there is one available in
Workspace which will be reused on next invocation.

The responsible events are passed from events.cpp to KillWindow for
processing.

In order to port the keycode to symbol to XCB, KWin now finds
xcb_keysyms and links it.

Currently there is one regression: the standard icon is used instead of
the user styled one.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindXCB.cmake <span style="color: \
grey">(7850c6831858ecd9f9d798d7a163115b2f0eeac9)</span></li>

 <li>kwin/CMakeLists.txt <span style="color: \
grey">(62e9964a60783456dd11958f7a105e9d4df110c2)</span></li>

 <li>kwin/events.cpp <span style="color: \
grey">(281f9e708d4488c504b8fc5eba3de5757a59c915)</span></li>

 <li>kwin/killwindow.h <span style="color: \
grey">(585331ade43c052ff1e7de0e4976fb0fae54d7b0)</span></li>

 <li>kwin/killwindow.cpp <span style="color: \
grey">(57e15e525a4428b80f5bc3c28d2934d7a4caa401)</span></li>

 <li>kwin/useractions.cpp <span style="color: \
grey">(3617d2938cfd2483a0fb7591ffbce102db482b61)</span></li>

 <li>kwin/workspace.h <span style="color: \
grey">(84163347d346d6381a4d825b560d30f04787e3c2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107945/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 