This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107945/

Wasn't there some review to remove the slot (or was it just the dbus interface?)

- Thomas


On December 27th, 2012, 2:03 p.m., Martin Gräßlin wrote:

Review request for kwin and Fredrik Höglund.
By Martin Gräßlin.

Updated Dec. 27, 2012, 2:03 p.m.

Description

Rewrite KillWindow on top of XCB

The code is rewritten in a way to replace the local event loop with event
filtering done in the normal way through events.cpp. Therefore instead of
creating a KillWindow whenever it's needed, there is one available in
Workspace which will be reused on next invocation.

The responsible events are passed from events.cpp to KillWindow for
processing.

In order to port the keycode to symbol to XCB, KWin now finds
xcb_keysyms and links it.

Currently there is one regression: the standard icon is used instead of
the user styled one.

Diffs

  • cmake/modules/FindXCB.cmake (7850c6831858ecd9f9d798d7a163115b2f0eeac9)
  • kwin/CMakeLists.txt (62e9964a60783456dd11958f7a105e9d4df110c2)
  • kwin/events.cpp (281f9e708d4488c504b8fc5eba3de5757a59c915)
  • kwin/killwindow.h (585331ade43c052ff1e7de0e4976fb0fae54d7b0)
  • kwin/killwindow.cpp (57e15e525a4428b80f5bc3c28d2934d7a4caa401)
  • kwin/useractions.cpp (3617d2938cfd2483a0fb7591ffbce102db482b61)
  • kwin/workspace.h (84163347d346d6381a4d825b560d30f04787e3c2)

View Diff