[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: improve multihead situation
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-23 20:17:12
Message-ID: 20121223201712.30845.64179 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107853/
-----------------------------------------------------------
(Updated Dec. 23, 2012, 8:17 p.m.)
Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
Description (updated)
-------
according to comment at bug #256242 (and on my own short term perception) t=
his improves the tabbox on multihead setups because the focus is not passed=
to the other head.
it does so by testing whether this kwin workspace singleton contains the wi=
ndow with input focus (to start action with)
Single head is special cased an patch runs here for quite some time (single=
head)
Diffs
-----
kwin/composite.cpp bc51425 =
kwin/tabbox/tabbox.cpp 0541e59 =
kwin/workspace.h 8416334 =
kwin/workspace.cpp b9e137d =
Diff: http://git.reviewboard.kde.org/r/107853/diff/
Testing
-------
"yes"
Thanks,
Thomas L=C3=BCbking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107853/">http://git.reviewboard.kde.org/r/107853/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2012, 8:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">according to comment at bug #256242 (and on my own short term \
perception) this improves the tabbox on multihead setups because the focus is not \
passed to the other head.
it does so by testing whether this kwin workspace singleton contains the window with \
input focus (to start action with) Single head is special cased an patch runs here \
for quite some time (single head)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"yes"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(bc51425)</span></li>
<li>kwin/tabbox/tabbox.cpp <span style="color: grey">(0541e59)</span></li>
<li>kwin/workspace.h <span style="color: grey">(8416334)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(b9e137d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107853/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic