'Re: Review Request: improve multihead situation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: improve multihead situation
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-23 20:17:02
Message-ID: 20121223201702.30845.24006 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Dec. 23, 2012, 8:38 a.m., Martin Gräßlin wrote:
> > kwin/workspace.cpp, lines 1813-1819
> > <http://git.reviewboard.kde.org/r/107853/diff/1/?file=100650#file100650line1813>
> > 
> > maybe use xcb for it, then we don't need to port ;-)

Is there any way to get the screen of a window that is not as stupid as traversing \
all windows on all screens and see whether we found it? It's not in the \
xcb_get_window_attributes_reply_t and seriously: given the ways to determine \
[Default]ScreenOfDisplay I assume the answer is "no"?

Also (I have to state that or i'll explode) xcb was certainly defined by some \
keyboard vendor and a drunken monkey? "xcb_window_t \
xcb_get_input_focus_reply_t.focus" m(

Seriously again:
Will we need some "ScopedCPointer<T> fetch_xcb_T()" macro? And typedefs like \
"namespace XCB { typedef ScopedCPointer<xcb_get_window_attributes_reply_t> \
WindowAttributes; }"?

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107853/#review23880
-----------------------------------------------------------

On Dec. 22, 2012, 10:53 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107853/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 10:53 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> according to comment (and on my own short term perception) this improves the tabbox \
> on multihead setups because the focus is not passed to the other head. 
> it does so by testing whether this kwin workspace singleton contains the window \
> with input focus (to start action with) Single head is special cased an patch runs \
> here for quite some time (single head) 
> 
> Diffs
> -----
> 
> kwin/composite.cpp bc51425 
> kwin/tabbox/tabbox.cpp 0541e59 
> kwin/workspace.h 8416334 
> kwin/workspace.cpp b9e137d 
> 
> Diff: http://git.reviewboard.kde.org/r/107853/diff/
> 
> 
> Testing
> -------
> 
> "yes"
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107853/">http://git.reviewboard.kde.org/r/107853/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 23rd, 2012, 8:38 a.m., <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/107853/diff/1/?file=100650#file100650line1813" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/workspace.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool Workspace::isOnCurrentHead()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1813</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">XGetInputFocus</span><span class="p">(</span><span \
class="n">display</span><span class="p">(),</span> <span class="o">&amp;</span><span \
class="n">focusWindow</span><span class="p">,</span> <span \
class="o">&amp;</span><span class="n">unused</span><span class="p">)</span> <span \
class="o">||</span> <span class="n">focusWindow</span> <span class="o">==</span> \
<span class="n">None</span><span class="p">)</span> <span class="c1">// should not \
happen<span class="ew"> </span></span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1814</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="o">!</span><span \
class="n">multiscreen</span><span class="p">;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1815</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">XWindowAttributes</span> <span class="n">attr</span><span \
class="p">;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1816</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">XGetWindowAttributes</span><span class="p">(</span><span \
class="n">display</span><span class="p">(),</span> <span \
class="n">focusWindow</span><span class="p">,</span> <span \
class="o">&amp;</span><span class="n">attr</span><span class="p">))</span> <span \
class="p">{</span> <span class="c1">// should not happen</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1817</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="o">!</span><span \
class="n">multiscreen</span><span class="p">;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1818</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1819</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">return</span> <span class="n">XDefaultScreenOfDisplay</span><span \
class="p">(</span><span class="n">display</span><span class="p">())</span> <span \
class="o">==</span> <span class="n">attr</span><span class="p">.</span><span \
class="n">screen</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe use xcb for it, \
then we don&#39;t need to port ;-)</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there \
any way to get the screen of a window that is not as stupid as traversing all windows \
on all screens and see whether we found it? It&#39;s not in the \
xcb_get_window_attributes_reply_t and seriously: given the ways to determine \
[Default]ScreenOfDisplay I assume the answer is &quot;no&quot;?

Also (I have to state that or i&#39;ll explode) xcb was certainly defined by some \
keyboard vendor and a drunken monkey? &quot;xcb_window_t \
xcb_get_input_focus_reply_t.focus&quot; m(

Seriously again:
Will we need some &quot;ScopedCPointer&lt;T&gt; fetch_xcb_T()&quot; macro? And \
typedefs like &quot;namespace XCB { typedef \
ScopedCPointer&lt;xcb_get_window_attributes_reply_t&gt; WindowAttributes; \
}&quot;?</pre> <br />

<p>- Thomas</p>

<br />
<p>On December 22nd, 2012, 10:53 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 22, 2012, 10:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">according to comment (and on my own short term perception) this improves \
the tabbox on multihead setups because the focus is not passed to the other head.

it does so by testing whether this kwin workspace singleton contains the window with \
input focus (to start action with) Single head is special cased an patch runs here \
for quite some time (single head)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&quot;yes&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(bc51425)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(0541e59)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(8416334)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(b9e137d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107853/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 