[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Plastik theme for Aurorae replaces the classic Plastik
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-09-27 16:31:53
Message-ID: 20120927163153.2393.58044 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106613/
-----------------------------------------------------------
Review request for kwin.
Description
-------
Plastik theme for Aurorae replaces the classic Plastik
* Update script to migrate Plastik users to Aurorae
* Plastik QML renamed to Plastik
* Old Plastik is dropped
Fix initial button flickering in Plastik QML
Disable animations till the decoration is completel loaded. This
ensures that the buttons do not flicker because of the animation from
black to their respective color.
Use a Component for Explicit Spacers
A component has the advantage that the width property can depend from
other properties. This does not work with the previous on the fly
construction as the width does not update when the referenced property
changes.
Diffs
-----
kwin/clients/CMakeLists.txt 6019a9e7aa9967f89907fb9b3dcb7874a75ea03d =
kwin/clients/aurorae/src/qml/ButtonGroup.qml 578bb753bfaf93ca41fc044b2443=
091df2072933 =
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 7805a50a=
ecb2a9cb6a540fabb1bf95d6b09956e0 =
kwin/clients/aurorae/themes/plastik/package/metadata.desktop 2565ccb8248c=
4ea530a2de11b98a7e9e5795e43a =
kwin/clients/plastik/CMakeLists.txt fce0829029aaddad5c0b52ae57827c72aff96=
e49 =
kwin/clients/plastik/config/CMakeLists.txt e48955d9babfc04c388af5139abe79=
7987f3b141 =
kwin/clients/plastik/config/config.h b037efefd29e4cc66ecf4535aa2f04f02b6d=
d2ce =
kwin/clients/plastik/config/config.cpp a4ddfe08ed133e7a8058f7af82b5f3926b=
d5eade =
kwin/clients/plastik/config/configdialog.ui fe9f53a5abbb18171503d27d519e8=
a03a7357875 =
kwin/clients/plastik/plastik.cpp d1a1147f4119daf94e8f577f7fcb7a18cc122a88 =
kwin/clients/plastik/plastik.desktop 30550c679890285ee3d0099ec31de7b8fb52=
83f6 =
kwin/clients/plastik/plastik.h ae7a46e122805344c329dd45677cc5ed6f602e8c =
kwin/clients/plastik/plastikbutton.h 395f628c66c67d8f77d43dd9b8e772a402ed=
03cc =
kwin/clients/plastik/plastikbutton.cpp db29d768184772152770e565ae37e30438=
d65248 =
kwin/clients/plastik/plastikclient.h 4c5b0d958684ed32ec816b8ed7a2ba775235=
17a5 =
kwin/clients/plastik/plastikclient.cpp 58f832432ffa99768aa129ad832cfb68d3=
c54282 =
kwin/data/CMakeLists.txt 2ce682de3bd04e0266e50a3dfbe3dfbf2dd5d1d0 =
kwin/data/kwin_update_410.upd PRE-CREATION =
kwin/data/update_kwin_410.cpp PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/106613/diff/
Testing
-------
used Plastik and called the migration script which successfully migrated my=
running KWin to Aurorae
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106613/">http://git.reviewboard.kde.org/r/106613/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plastik theme for Aurorae replaces the classic Plastik
* Update script to migrate Plastik users to Aurorae
* Plastik QML renamed to Plastik
* Old Plastik is dropped
Fix initial button flickering in Plastik QML
Disable animations till the decoration is completel loaded. This
ensures that the buttons do not flicker because of the animation from
black to their respective color.
Use a Component for Explicit Spacers
A component has the advantage that the width property can depend from
other properties. This does not work with the previous on the fly
construction as the width does not update when the referenced property
changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">used Plastik and called the migration script which successfully migrated \
my running KWin to Aurorae</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/CMakeLists.txt <span style="color: \
grey">(6019a9e7aa9967f89907fb9b3dcb7874a75ea03d)</span></li>
<li>kwin/clients/aurorae/src/qml/ButtonGroup.qml <span style="color: \
grey">(578bb753bfaf93ca41fc044b2443091df2072933)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(7805a50aecb2a9cb6a540fabb1bf95d6b09956e0)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/metadata.desktop <span style="color: \
grey">(2565ccb8248c4ea530a2de11b98a7e9e5795e43a)</span></li>
<li>kwin/clients/plastik/CMakeLists.txt <span style="color: \
grey">(fce0829029aaddad5c0b52ae57827c72aff96e49)</span></li>
<li>kwin/clients/plastik/config/CMakeLists.txt <span style="color: \
grey">(e48955d9babfc04c388af5139abe797987f3b141)</span></li>
<li>kwin/clients/plastik/config/config.h <span style="color: \
grey">(b037efefd29e4cc66ecf4535aa2f04f02b6dd2ce)</span></li>
<li>kwin/clients/plastik/config/config.cpp <span style="color: \
grey">(a4ddfe08ed133e7a8058f7af82b5f3926bd5eade)</span></li>
<li>kwin/clients/plastik/config/configdialog.ui <span style="color: \
grey">(fe9f53a5abbb18171503d27d519e8a03a7357875)</span></li>
<li>kwin/clients/plastik/plastik.cpp <span style="color: \
grey">(d1a1147f4119daf94e8f577f7fcb7a18cc122a88)</span></li>
<li>kwin/clients/plastik/plastik.desktop <span style="color: \
grey">(30550c679890285ee3d0099ec31de7b8fb5283f6)</span></li>
<li>kwin/clients/plastik/plastik.h <span style="color: \
grey">(ae7a46e122805344c329dd45677cc5ed6f602e8c)</span></li>
<li>kwin/clients/plastik/plastikbutton.h <span style="color: \
grey">(395f628c66c67d8f77d43dd9b8e772a402ed03cc)</span></li>
<li>kwin/clients/plastik/plastikbutton.cpp <span style="color: \
grey">(db29d768184772152770e565ae37e30438d65248)</span></li>
<li>kwin/clients/plastik/plastikclient.h <span style="color: \
grey">(4c5b0d958684ed32ec816b8ed7a2ba77523517a5)</span></li>
<li>kwin/clients/plastik/plastikclient.cpp <span style="color: \
grey">(58f832432ffa99768aa129ad832cfb68d3c54282)</span></li>
<li>kwin/data/CMakeLists.txt <span style="color: \
grey">(2ce682de3bd04e0266e50a3dfbe3dfbf2dd5d1d0)</span></li>
<li>kwin/data/kwin_update_410.upd <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/data/update_kwin_410.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106613/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic