'Re: Review Request: Fix enabled borders and padding for maximized Aurorae decos'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix enabled borders and padding for maximized Aurorae decos
From:       "Commit Hook" <null () kde ! org>
Date:       2012-09-27 13:34:56
Message-ID: 20120927133456.29322.30779 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106576/#review19496
-----------------------------------------------------------

This review has been submitted with commit fd1e76c03ea8701b6118016a3864b315bf09cbda \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On Sept. 25, 2012, 8:30 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106576/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 8:30 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Fix enabled borders and padding for maximized Aurorae decos
> 
> In the maximized state the enabled borders were still enabled causing
> the actual borders to be still shown. In addition the padding is not
> adjusted to be 0. This is done in the C++ part is it does not make any
> sense to have shadows being thrown to another screen for a maximized
> window.
> 
> BUG: 307365
> 
> 
> This addresses bug 307365.
> http://bugs.kde.org/show_bug.cgi?id=307365
> 
> 
> Diffs
> -----
> 
> kwin/clients/aurorae/src/aurorae.cpp 4277b65befbcffd62be8701ccb7afda13cb1e58e 
> kwin/clients/aurorae/src/qml/AuroraeButtonGroup.qml \
> 89916f07f40c98053e63c2ef20c6cc28e6108303  kwin/clients/aurorae/src/qml/aurorae.qml \
> acd6d7aa37402ceb94625919a065d87bb7c5bebf  
> Diff: http://git.reviewboard.kde.org/r/106576/diff/
> 
> 
> Testing
> -------
> 
> Tried various decos on master. Not yet tested in a 4.9 only build
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106576/">http://git.reviewboard.kde.org/r/106576/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fd1e76c03ea8701b6118016a3864b315bf09cbda by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 25th, 2012, 8:30 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 25, 2012, 8:30 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix enabled borders and padding for maximized Aurorae decos

In the maximized state the enabled borders were still enabled causing
the actual borders to be still shown. In addition the padding is not
adjusted to be 0. This is done in the C++ part is it does not make any
sense to have shadows being thrown to another screen for a maximized
window.

BUG: 307365</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried various decos on master. Not yet tested in a 4.9 only build</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=307365">307365</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(4277b65befbcffd62be8701ccb7afda13cb1e58e)</span></li>

 <li>kwin/clients/aurorae/src/qml/AuroraeButtonGroup.qml <span style="color: \
grey">(89916f07f40c98053e63c2ef20c6cc28e6108303)</span></li>

 <li>kwin/clients/aurorae/src/qml/aurorae.qml <span style="color: \
grey">(acd6d7aa37402ceb94625919a065d87bb7c5bebf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106576/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 