[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Use KConfigXT in WindowGeometry
From: "Commit Hook" <null () kde ! org>
Date: 2012-09-19 8:32:34
Message-ID: 20120919083234.4393.37454 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106413/#review19148
-----------------------------------------------------------
This review has been submitted with commit 02f8c14a6e3ac716d523f1a03da771fb=
59622628 by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit Hook
On Sept. 10, 2012, 1:35 p.m., Andrea Scarpino wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106413/
> -----------------------------------------------------------
> =
> (Updated Sept. 10, 2012, 1:35 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Use KConfigXT in WindowGeometry.
> =
> I don't know what to do with myUi->shortcuts in the default() method and =
in the WindowGeometryConfig constructor.
> =
> =
> Diffs
> -----
> =
> kwin/effects/windowgeometry/CMakeLists.txt acf2474 =
> kwin/effects/windowgeometry/windowgeometry.cpp 5119f7e =
> kwin/effects/windowgeometry/windowgeometry.kcfg PRE-CREATION =
> kwin/effects/windowgeometry/windowgeometry_config.h 76b1054 =
> kwin/effects/windowgeometry/windowgeometry_config.cpp be48b1c =
> kwin/effects/windowgeometry/windowgeometry_config.ui 2b8e8a6 =
> kwin/effects/windowgeometry/windowgeometryconfig.kcfgc PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106413/diff/
> =
> =
> Testing
> -------
> =
> It builds
> =
> =
> Thanks,
> =
> Andrea Scarpino
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106413/">http://git.reviewboard.kde.org/r/106413/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 02f8c14a6e3ac716d523f1a03da771fb59622628 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 10th, 2012, 1:35 p.m., Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2012, 1:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KConfigXT in WindowGeometry.
I don't know what to do with myUi->shortcuts in the default() method and in \
the WindowGeometryConfig constructor.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/windowgeometry/CMakeLists.txt <span style="color: \
grey">(acf2474)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.cpp <span style="color: \
grey">(5119f7e)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.h <span style="color: \
grey">(76b1054)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.cpp <span style="color: \
grey">(be48b1c)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry_config.ui <span style="color: \
grey">(2b8e8a6)</span></li>
<li>kwin/effects/windowgeometry/windowgeometryconfig.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106413/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic