'Re: Review Request: Use KConfigXT in MagicLamp effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use KConfigXT in MagicLamp effect
From:       "Commit Hook" <null () kde ! org>
Date:       2012-09-19 8:32:34
Message-ID: 20120919083234.4384.60976 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106412/#review19147
-----------------------------------------------------------

This review has been submitted with commit f523d825da0728fcb06ead901dd7ef26=
3f662858 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Sept. 10, 2012, 7:15 a.m., Andrea Scarpino wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106412/
> -----------------------------------------------------------
> =

> (Updated Sept. 10, 2012, 7:15 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Use KConfigXT in MagicLamp effect
> =

> I don't know how to handle the others option in the reconfigure method, s=
hould I add them in the kcfg file?
> Also, which is the default value for the AnimationDuration, 0 or 250?
> =

> =

> Diffs
> -----
> =

>   kwin/effects/magiclamp/CMakeLists.txt 81e42fd =

>   kwin/effects/magiclamp/magiclamp.cpp e5c1018 =

>   kwin/effects/magiclamp/magiclamp.kcfg PRE-CREATION =

>   kwin/effects/magiclamp/magiclamp_config.h edb1a84 =

>   kwin/effects/magiclamp/magiclamp_config.cpp a1822af =

>   kwin/effects/magiclamp/magiclamp_config.ui c7ae156 =

>   kwin/effects/magiclamp/magiclampconfig.kcfgc PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/106412/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Andrea Scarpino
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106412/">http://git.reviewboard.kde.org/r/106412/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f523d825da0728fcb06ead901dd7ef263f662858 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 10th, 2012, 7:15 a.m., Andrea Scarpino wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Andrea Scarpino.</div>

<p style="color: grey;"><i>Updated Sept. 10, 2012, 7:15 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KConfigXT in MagicLamp effect

I don&#39;t know how to handle the others option in the reconfigure method, should I \
add them in the kcfg file? Also, which is the default value for the \
AnimationDuration, 0 or 250?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/magiclamp/CMakeLists.txt <span style="color: \
grey">(81e42fd)</span></li>

 <li>kwin/effects/magiclamp/magiclamp.cpp <span style="color: \
grey">(e5c1018)</span></li>

 <li>kwin/effects/magiclamp/magiclamp.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/magiclamp/magiclamp_config.h <span style="color: \
grey">(edb1a84)</span></li>

 <li>kwin/effects/magiclamp/magiclamp_config.cpp <span style="color: \
grey">(a1822af)</span></li>

 <li>kwin/effects/magiclamp/magiclamp_config.ui <span style="color: \
grey">(c7ae156)</span></li>

 <li>kwin/effects/magiclamp/magiclampconfig.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106412/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 