[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fix fullscreen effect flicker
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-28 19:51:42
Message-ID: 20120828195142.3720.67044 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106142/#review18193
-----------------------------------------------------------
This review has been submitted with commit 33724eee626872abeb15149d22cf5f28d0d7ecef by Thomas Lübking to \
branch master.
- Commit Hook
On Aug. 23, 2012, 3:13 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106142/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2012, 3:13 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> actually wasn't about the swapinterval (just on nvidia, where the issue was gone with the 304 driver)
>
> The fullscreen effects require some "slide into buffer swapping" - to not make the entire thing to \
> expensive for the simple painting the patch exports whether there's a pending flush and invokes that in \
> the decision whether having to do some "dead" flushes (ie. trigger paint w/o actual pending)
> Background:
> during a fullscreen effect the m_lastDamage is always not empty (so ::paint() will flush / swap buffers \
> ratther unconditional) Otherwise it will be empty after the wanted patch so we can just idle but for \
> the fullscreen effect the buffers need to be harmonized. (The former s_pending covered that \
> insufficiently)
>
> This addresses bug 304375.
> http://bugs.kde.org/show_bug.cgi?id=304375
>
>
> Diffs
> -----
>
> kwin/composite.cpp c65716b
> kwin/scene.h 3891198
> kwin/scene_opengl.h de33ce4
>
> Diff: http://git.reviewboard.kde.org/r/106142/diff/
>
>
> Testing
> -------
>
> Yes. Also ensured there's still idling.
>
> Did NOT test EGL so far (but i doubt it's an issue at all - ideally it can or will idle immediately in \
> fullscreen mode as well because there's no "legacy" back -> front copying)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106142/">http://git.reviewboard.kde.org/r/106142/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
33724eee626872abeb15149d22cf5f28d0d7ecef by Thomas Lübking to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 23rd, 2012, 3:13 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2012, 3:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">actually wasn't about the swapinterval \
(just on nvidia, where the issue was gone with the 304 driver)
The fullscreen effects require some "slide into buffer swapping" - to not make the entire thing \
to expensive for the simple painting the patch exports whether there's a pending flush and invokes \
that in the decision whether having to do some "dead" flushes (ie. trigger paint w/o actual \
pending)
Background:
during a fullscreen effect the m_lastDamage is always not empty (so ::paint() will flush / swap buffers \
ratther unconditional) Otherwise it will be empty after the wanted patch so we can just idle but for the \
fullscreen effect the buffers need to be harmonized. (The former s_pending covered that \
insufficiently)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. Also ensured there's still idling.
Did NOT test EGL so far (but i doubt it's an issue at all - ideally it can or will idle immediately \
in fullscreen mode as well because there's no "legacy" back -> front copying)</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304375">304375</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(c65716b)</span></li>
<li>kwin/scene.h <span style="color: grey">(3891198)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(de33ce4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106142/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic