--===============7527090820543506879== Content-Type: multipart/alternative; boundary="===============3850733510445498045==" --===============3850733510445498045== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106142/#review18193 ----------------------------------------------------------- This review has been submitted with commit 33724eee626872abeb15149d22cf5f28= d0d7ecef by Thomas L=C3=BCbking to branch master. - Commit Hook On Aug. 23, 2012, 3:13 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106142/ > ----------------------------------------------------------- > = > (Updated Aug. 23, 2012, 3:13 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > actually wasn't about the swapinterval (just on nvidia, where the issue w= as gone with the 304 driver) > = > The fullscreen effects require some "slide into buffer swapping" - to not= make the entire thing to expensive for the simple painting the patch expor= ts whether there's a pending flush and invokes that in the decision whether= having to do some "dead" flushes (ie. trigger paint w/o actual pending) > = > Background: > during a fullscreen effect the m_lastDamage is always not empty (so ::pai= nt() will flush / swap buffers ratther unconditional) > Otherwise it will be empty after the wanted patch so we can just idle but= for the fullscreen effect the buffers need to be harmonized. > (The former s_pending covered that insufficiently) > = > = > This addresses bug 304375. > http://bugs.kde.org/show_bug.cgi?id=3D304375 > = > = > Diffs > ----- > = > kwin/composite.cpp c65716b = > kwin/scene.h 3891198 = > kwin/scene_opengl.h de33ce4 = > = > Diff: http://git.reviewboard.kde.org/r/106142/diff/ > = > = > Testing > ------- > = > Yes. Also ensured there's still idling. > = > Did NOT test EGL so far (but i doubt it's an issue at all - ideally it ca= n or will idle immediately in fullscreen mode as well because there's no "l= egacy" back -> front copying) > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============3850733510445498045== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106142/ 

This revie=
w has been submitted with commit 33724eee626872abeb15149d22cf5f28d0d7ecef b=
y Thomas L=C3=BCbking to branch master.

- Commit


On August 23rd, 2012, 3:13 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Aug. 23, 2012, 3:13 p.m.

Descripti= on 

actually wasn't about the swapinterval (just on nvidia, =
where the issue was gone with the 304 driver)

The fullscreen effects require some "slide into buffer swapping" =
- to not make the entire thing to expensive for the simple painting the pat=
ch exports whether there's a pending flush and invokes that in the deci=
sion whether having to do some "dead" flushes (ie. trigger paint =
w/o actual pending)

Background:
during a fullscreen effect the m_lastDamage is always not empty (so ::paint=
() will flush / swap buffers ratther unconditional)
Otherwise it will be empty after the wanted patch so we can just idle but f=
or the fullscreen effect the buffers need to be harmonized.
(The former s_pending covered that insufficiently)

Testing <= /h1> 
Yes. Also ensured there's still idling.

Did NOT test EGL so far (but i doubt it's an issue at all - ideally it =
can or will idle immediately in fullscreen mode as well because there's=
 no "legacy" back -> front copying)
Bugs: 304375

Diffs=

  • kwin/composite.cpp (c65716b)
  • kwin/scene.h (3891198)
  • kwin/scene_opengl.h (de33ce4)

View Diff
--===============3850733510445498045==-- --===============7527090820543506879== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============7527090820543506879==--