'Re: Review Request: fix untab geometry'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: fix untab geometry
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-08-28 16:44:11
Message-ID: 20120828164411.19642.31096 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106182/
-----------------------------------------------------------

(Updated Aug. 28, 2012, 4:44 p.m.)

Review request for kwin and Martin Gräßlin.

Changes
-------

- change if if -> if &&
- introduce common cascadeOffset function

Description
-------

is broken (clients always end up in the same position because of \
checkWorkspacePosition() and the recursion - also when tabbing out of a maximized \
client, things become tricky, because the suggested geometry will be the maximized \
one) and i "fixed" that bug btw.

This addresses bug 226881.
    http://bugs.kde.org/show_bug.cgi?id=226881

Diffs (updated)
-----

  kwin/client.cpp 09b0328 
  kwin/placement.cpp f091d9d 
  kwin/tabgroup.h 3ad0a08 
  kwin/tabgroup.cpp 771d789 
  kwin/useractions.cpp deb6507 
  kwin/workspace.h 1fa0c20 

Diff: http://git.reviewboard.kde.org/r/106182/diff/

Testing
-------

why was this deleted?

yes - tabbed out of normal, max'd and QT'd windows with pointer DnD and context menu \
action

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106182/">http://git.reviewboard.kde.org/r/106182/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2012, 4:44 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- change if if -&gt; if &amp;&amp;
- introduce common cascadeOffset function</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">is broken (clients always end up in the same position because of \
checkWorkspacePosition() and the recursion - also when tabbing out of a maximized \
client, things become tricky, because the suggested geometry will be the maximized \
one) and i &quot;fixed&quot; that bug btw.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">why was this deleted?

yes - tabbed out of normal, max&#39;d and QT&#39;d windows with pointer DnD and \
context menu action</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=226881">226881</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(09b0328)</span></li>

 <li>kwin/placement.cpp <span style="color: grey">(f091d9d)</span></li>

 <li>kwin/tabgroup.h <span style="color: grey">(3ad0a08)</span></li>

 <li>kwin/tabgroup.cpp <span style="color: grey">(771d789)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(deb6507)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(1fa0c20)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106182/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 