[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fix untab geometry
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-28 4:32:10
Message-ID: 20120828043210.31033.46926 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 27, 2012, 8:42 p.m., Martin Gräßlin wrote:
> > kwin/useractions.cpp, line 1427
> > <http://git.reviewboard.kde.org/r/106182/diff/2/?file=81133#file81133line1427>
> >
> > maybe I'm missing something, but where does the 32 come from?
>
> Thomas Lübking wrote:
> Completely random out of my mind.
>
> The bug correctly concerns that if you untab a window (from the context menu) it \
> ends up right where it was and above it's siblings what's a confusing effect. So i \
> set it off a bit - and if i pick "random" numbers, it's usually a power of 2 =)
> I could add a static const or #define to have a name for it.
in Placement::placeCascaded it uses 24. Might make sense to share those two
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106182/#review18131
-----------------------------------------------------------
On Aug. 25, 2012, 7:04 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106182/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2012, 7:04 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> is broken (clients always end up in the same position because of \
> checkWorkspacePosition() and the recursion - also when tabbing out of a maximized \
> client, things become tricky, because the suggested geometry will be the maximized \
> one) and i "fixed" that bug btw.
>
> This addresses bug 226881.
> http://bugs.kde.org/show_bug.cgi?id=226881
>
>
> Diffs
> -----
>
> kwin/client.cpp 09b0328
> kwin/tabgroup.h 3ad0a08
> kwin/tabgroup.cpp 771d789
> kwin/useractions.cpp deb6507
>
> Diff: http://git.reviewboard.kde.org/r/106182/diff/
>
>
> Testing
> -------
>
> why was this deleted?
>
> yes - tabbed out of normal, max'd and QT'd windows with pointer DnD and context \
> menu action
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106182/">http://git.reviewboard.kde.org/r/106182/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2012, 8:42 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106182/diff/2/?file=81133#file81133line1427" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/useractions.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Workspace::slotActivatePrevTab()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1427</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">active_client</span><span class="o">-></span><span \
class="n">untab</span><span class="p">();</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1427</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">active_client</span><span class="o">-></span><span \
class="n">untab</span><span class="p">(</span><span \
class="n">active_client</span><span class="o">-></span><span \
class="n">geometry</span><span class="p">().</span><span \
class="n">translated</span><span class="p">(</span><span class="mi">32</span><span \
class="p">,</span><span class="mi">32</span><span class="p">));</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe I'm missing \
something, but where does the 32 come from?</pre> </blockquote>
<p>On August 27th, 2012, 10:36 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completely random out of \
my mind.
The bug correctly concerns that if you untab a window (from the context menu) it ends \
up right where it was and above it's siblings what's a confusing effect. So i \
set it off a bit - and if i pick "random" numbers, it's usually a power \
of 2 =)
I could add a static const or #define to have a name for it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in \
Placement::placeCascaded it uses 24. Might make sense to share those two</pre> <br />
<p>- Martin</p>
<br />
<p>On August 25th, 2012, 7:04 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2012, 7:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">is broken (clients always end up in the same position because of \
checkWorkspacePosition() and the recursion - also when tabbing out of a maximized \
client, things become tricky, because the suggested geometry will be the maximized \
one) and i "fixed" that bug btw.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">why was this deleted?
yes - tabbed out of normal, max'd and QT'd windows with pointer DnD and \
context menu action</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=226881">226881</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(09b0328)</span></li>
<li>kwin/tabgroup.h <span style="color: grey">(3ad0a08)</span></li>
<li>kwin/tabgroup.cpp <span style="color: grey">(771d789)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(deb6507)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106182/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic