[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Fix slidingpopups behavior
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-28 13:12:58
Message-ID: 20120828131258.2403.66335 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106247/
-----------------------------------------------------------
Review request for kwin.
Description
-------
if i call something like
Plasma::WindowEffects::slideWindow(m_view->winId(), Plasma::BottomEdge, 0);
i expect the window sliding in and out from the bottom edge of the screen, =
even if the window is not physically attached to the screen bottom edge.
right now it only produces garbage on the screen (some frames of the animat=
ion that don't get cleared out)
this patch makes it work, maintaining the same behavior for existing popups
Diffs
-----
kwin/effects/slidingpopups/slidingpopups.cpp 8ffad4d =
Diff: http://git.reviewboard.kde.org/r/106247/diff/
Testing
-------
Thanks,
Marco Martin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106247/">http://git.reviewboard.kde.org/r/106247/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if i call something like \
Plasma::WindowEffects::slideWindow(m_view->winId(), Plasma::BottomEdge, \
0);
i expect the window sliding in and out from the bottom edge of the screen, \
even if the window is not physically attached to the screen bottom edge.
right now it only produces garbage on the screen (some frames of the \
animation that don't get cleared out) this patch makes it work, \
maintaining the same behavior for existing popups</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(8ffad4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106247/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic