From kwin Tue Aug 28 13:12:58 2012 From: "Marco Martin" Date: Tue, 28 Aug 2012 13:12:58 +0000 To: kwin Subject: Review Request: Fix slidingpopups behavior Message-Id: <20120828131258.2403.66335 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=134615959005872 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6064740412336957026==" --===============6064740412336957026== Content-Type: multipart/alternative; boundary="===============5733048615577682713==" --===============5733048615577682713== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106247/ ----------------------------------------------------------- Review request for kwin. Description ------- if i call something like Plasma::WindowEffects::slideWindow(m_view->winId(), Plasma::BottomEdge, 0); i expect the window sliding in and out from the bottom edge of the screen, = even if the window is not physically attached to the screen bottom edge. right now it only produces garbage on the screen (some frames of the animat= ion that don't get cleared out) this patch makes it work, maintaining the same behavior for existing popups Diffs ----- kwin/effects/slidingpopups/slidingpopups.cpp 8ffad4d = Diff: http://git.reviewboard.kde.org/r/106247/diff/ Testing ------- Thanks, Marco Martin --===============5733048615577682713== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106247/

Review request for kwin.

By Marco Martin.

Descripti= on

if i call something like
Plasma::WindowEffects::slideWindow(m_view->winId(), Plasma::BottomEdge, =
0);

i expect the window sliding in and out from the bottom edge of the screen, =
even if the window is not physically attached to the screen bottom edge.

right now it only produces garbage on the screen (some frames of the animat=
ion that don't get cleared out)
this patch makes it work, maintaining the same behavior for existing popups=

Diffs=

kwin/effects/slidingpopups/slidingpopups.cpp (8ffad4d)

View Diff

--===============5733048615577682713==-- --===============6064740412336957026== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6064740412336957026==--