'Re: Review Request: ::tabIndexAt() usually means the index to tab before...'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: ::tabIndexAt() usually means the index to tab before...
From:       "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date:       2012-08-27 22:04:14
Message-ID: 20120827220414.10694.50322 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Aug. 27, 2012, 10:02 p.m., Hugo Pereira Da Costa wrote:
> > Ship It!

As a matter of fact, working on bug #305433, I came to the same change,
now the patch is incomplete. Further changes are needed (as far as I can tell) to \
make the visualization match the actual drop position. Maybe we should rather discard \
this review and let me fix the full thing. Still testing ... 

- Hugo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106149/#review18145
-----------------------------------------------------------

On Aug. 23, 2012, 8:58 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106149/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 8:58 p.m.)
> 
> 
> Review request for kwin and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> summarized
> 
> 
> This addresses bug 305443.
> http://bugs.kde.org/show_bug.cgi?id=305443
> 
> 
> Diffs
> -----
> 
> kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb 
> 
> Diff: http://git.reviewboard.kde.org/r/106149/diff/
> 
> 
> Testing
> -------
> 
> yes, tabs where the indicator says
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106149/">http://git.reviewboard.kde.org/r/106149/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 27th, 2012, 10:02 p.m., <b>Hugo Pereira \
Da Costa</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a matter of fact, \
working on bug #305433, I came to the same change, now the patch is incomplete. \
Further changes are needed (as far as I can tell) to make the visualization match the \
actual drop position. Maybe we should rather discard this review and let me fix the \
full thing. Still testing ... </pre> <br />

<p>- Hugo</p>

<br />
<p>On August 23rd, 2012, 8:58 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 23, 2012, 8:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, tabs where the indicator says</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=305443">305443</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(5fbb4fb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106149/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 