--===============2777851636119538162== Content-Type: multipart/alternative; boundary="===============4906661164536194788==" --===============4906661164536194788== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 27, 2012, 10:02 p.m., Hugo Pereira Da Costa wrote: > > Ship It! As a matter of fact, working on bug #305433, I came to the same change, now the patch is incomplete. Further changes are needed (as far as I can te= ll) to make the visualization match the actual drop position. Maybe we should rather discard this review and let me fix the full thing. S= till testing ... = - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106149/#review18145 ----------------------------------------------------------- On Aug. 23, 2012, 8:58 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106149/ > ----------------------------------------------------------- > = > (Updated Aug. 23, 2012, 8:58 p.m.) > = > = > Review request for kwin and Hugo Pereira Da Costa. > = > = > Description > ------- > = > summarized > = > = > This addresses bug 305443. > http://bugs.kde.org/show_bug.cgi?id=3D305443 > = > = > Diffs > ----- > = > kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb = > = > Diff: http://git.reviewboard.kde.org/r/106149/diff/ > = > = > Testing > ------- > = > yes, tabs where the indicator says > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============4906661164536194788== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106149/

On August 27th, 2012, 10:02 p.m., Hugo Pere= ira Da Costa wrote:

Ship It!<=
/pre>
 
As a matter=
 of fact, working on bug #305433, I came to the same change,
now the patch is incomplete. Further changes are needed (as far as I can te=
ll) to make the visualization match the actual drop position.
Maybe we should rather discard this review and let me fix the full thing. S=
till testing ...

- Hugo


On August 23rd, 2012, 8:58 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Hugo Pereira Da Costa.
By Thomas L=C3=BCbking.

Updated Aug. 23, 2012, 8:58 p.m.

Descripti= on 

summarized

Testing <= /h1> 
yes, tabs where the indicator says
Bugs: 305443

Diffs=

  • kwin/clients/oxygen/oxygenclient.cpp (5fbb= 4fb)

View Diff
--===============4906661164536194788==-- --===============2777851636119538162== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2777851636119538162==--