'Re: Review Request: Split the User Actions Menu out of Workspace'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Split the User Actions Menu out of Workspace
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-26 18:35:52
Message-ID: 20120826183552.18684.8493 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106085/#review18046
-----------------------------------------------------------

This review has been submitted with commit acbfed1e564d5e6103988e4697da3127=
f42fd9ed by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Aug. 19, 2012, 11:03 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106085/
> -----------------------------------------------------------
> =

> (Updated Aug. 19, 2012, 11:03 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Split the User Actions Menu out of Workspace
> =

> All methods and variables related to the User Actions Menu
> (rmb window deco, Alt+F3) is moved out of the Workspace class
> into an own UserActionsMenu class.
> =

> The class needs only a very small public interface containing
> methods to show the menu for a Client, closing the menu and
> discarding the menu. Everything else is actually private to the
> implementation which is one of the reasons why it makes sense
> to split the functionality out of the Workspace class.
> =

> As a result the methods and variables have more sane names and
> the variable names are standardized.
> =

> =

> Diffs
> -----
> =

>   kwin/activation.cpp 7c07d5e1bb7f0ae95e2adda0304b169ed27f7142 =

>   kwin/composite.cpp c65716b5cac13f8eef946679f9ded087a379a961 =

>   kwin/events.cpp 6856922e76334fcaa7121bb4adba7b88a627adcc =

>   kwin/useractions.h PRE-CREATION =

>   kwin/useractions.cpp a50178256f58cc88c84b2ca77812df620131d279 =

>   kwin/workspace.h 16630f756907d70598e7bf5a4e5225353ff1d58d =

>   kwin/workspace.cpp cf3f308a863cb0329003983244ba029876e9b790 =

> =

> Diff: http://git.reviewboard.kde.org/r/106085/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106085/">http://git.reviewboard.kde.org/r/106085/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit acbfed1e564d5e6103988e4697da3127f42fd9ed by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 19th, 2012, 11:03 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 19, 2012, 11:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Split the User Actions Menu out of Workspace

All methods and variables related to the User Actions Menu
(rmb window deco, Alt+F3) is moved out of the Workspace class
into an own UserActionsMenu class.

The class needs only a very small public interface containing
methods to show the menu for a Client, closing the menu and
discarding the menu. Everything else is actually private to the
implementation which is one of the reasons why it makes sense
to split the functionality out of the Workspace class.

As a result the methods and variables have more sane names and
the variable names are standardized.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/activation.cpp <span style="color: \
grey">(7c07d5e1bb7f0ae95e2adda0304b169ed27f7142)</span></li>

 <li>kwin/composite.cpp <span style="color: \
grey">(c65716b5cac13f8eef946679f9ded087a379a961)</span></li>

 <li>kwin/events.cpp <span style="color: \
grey">(6856922e76334fcaa7121bb4adba7b88a627adcc)</span></li>

 <li>kwin/useractions.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/useractions.cpp <span style="color: \
grey">(a50178256f58cc88c84b2ca77812df620131d279)</span></li>

 <li>kwin/workspace.h <span style="color: \
grey">(16630f756907d70598e7bf5a4e5225353ff1d58d)</span></li>

 <li>kwin/workspace.cpp <span style="color: \
grey">(cf3f308a863cb0329003983244ba029876e9b790)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106085/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 