This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106085/

This review has been submitted with commit acbfed1e564d5e6103988e4697da3127f42fd9ed by Martin Gräßlin to branch master.

- Commit


On August 19th, 2012, 11:03 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 19, 2012, 11:03 a.m.

Description

Split the User Actions Menu out of Workspace

All methods and variables related to the User Actions Menu
(rmb window deco, Alt+F3) is moved out of the Workspace class
into an own UserActionsMenu class.

The class needs only a very small public interface containing
methods to show the menu for a Client, closing the menu and
discarding the menu. Everything else is actually private to the
implementation which is one of the reasons why it makes sense
to split the functionality out of the Workspace class.

As a result the methods and variables have more sane names and
the variable names are standardized.

Diffs

  • kwin/activation.cpp (7c07d5e1bb7f0ae95e2adda0304b169ed27f7142)
  • kwin/composite.cpp (c65716b5cac13f8eef946679f9ded087a379a961)
  • kwin/events.cpp (6856922e76334fcaa7121bb4adba7b88a627adcc)
  • kwin/useractions.h (PRE-CREATION)
  • kwin/useractions.cpp (a50178256f58cc88c84b2ca77812df620131d279)
  • kwin/workspace.h (16630f756907d70598e7bf5a4e5225353ff1d58d)
  • kwin/workspace.cpp (cf3f308a863cb0329003983244ba029876e9b790)

View Diff