[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: delay unsynced showing by at max 50ms
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-25 13:46:41
Message-ID: 20120825134641.22532.46098 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106173/#review17987
-----------------------------------------------------------
What happens if the Window gets deleted before the first damage event? Does that \
cause any issues for the Deleted?
kwin/effects.cpp
<http://git.reviewboard.kde.org/r/106173/#comment14223>
qobject_cast?
- Martin Gräßlin
On Aug. 24, 2012, 9:08 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106173/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2012, 9:08 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> to workaround that bug / issue
> The very first damage event will still cause a full repaint (with \
> setReadyForPainting)
>
> This addresses bug 295254.
> http://bugs.kde.org/show_bug.cgi?id=295254
>
>
> Diffs
> -----
>
> kwin/client.cpp 09b0328
> kwin/composite.cpp 12bb75a
> kwin/effects.h 014c4cf
> kwin/effects.cpp f3fd7e5
> kwin/toplevel.h aba9321
> kwin/toplevel.cpp 9417813
> kwin/unmanaged.h b11d62b
>
> Diff: http://git.reviewboard.kde.org/r/106173/diff/
>
>
> Testing
> -------
>
> gimp testcase i mentioned in the bug. works.
> Also even with a significant test delay (250ms) the windows still nearly map \
> immediately (for the initial damage event)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106173/">http://git.reviewboard.kde.org/r/106173/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What happens if the \
Window gets deleted before the first damage event? Does that cause any issues for the \
Deleted?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106173/diff/1/?file=80964#file80964line435" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void EffectsHandlerImpl::slotUnmanagedShown(KWin::Toplevel *t)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">429</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_ASSERT</span><span class="p">(</span><span \
class="k">dynamic_cast</span><span class="o"><</span><span \
class="n">Unmanaged</span><span class="o">*></span><span class="p">(</span><span \
class="n">t</span><span class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">430</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Unmanaged</span> <span class="o">*</span><span class="n">u</span> <span \
class="o">=</span> <span class="k">static_cast</span><span class="o"><</span><span \
class="n">Unmanaged</span><span class="o">*></span><span class="p">(</span><span \
class="n">t</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">qobject_cast?</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On August 24th, 2012, 9:08 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2012, 9:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">to workaround that bug / issue The very first damage event will still \
cause a full repaint (with setReadyForPainting)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">gimp testcase i mentioned in the bug. works. Also even with a \
significant test delay (250ms) the windows still nearly map immediately (for the \
initial damage event)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295254">295254</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(09b0328)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(12bb75a)</span></li>
<li>kwin/effects.h <span style="color: grey">(014c4cf)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(f3fd7e5)</span></li>
<li>kwin/toplevel.h <span style="color: grey">(aba9321)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(9417813)</span></li>
<li>kwin/unmanaged.h <span style="color: grey">(b11d62b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106173/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic