[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: delay unsynced showing by at max 50ms
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-08-24 21:08:22
Message-ID: 20120824210822.23604.63765 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106173/
-----------------------------------------------------------
Review request for kwin and Martin Gräßlin.
Description
-------
to workaround that bug / issue
The very first damage event will still cause a full repaint (with \
setReadyForPainting)
This addresses bug 295254.
http://bugs.kde.org/show_bug.cgi?id=295254
Diffs
-----
kwin/client.cpp 09b0328
kwin/composite.cpp 12bb75a
kwin/effects.h 014c4cf
kwin/effects.cpp f3fd7e5
kwin/toplevel.h aba9321
kwin/toplevel.cpp 9417813
kwin/unmanaged.h b11d62b
Diff: http://git.reviewboard.kde.org/r/106173/diff/
Testing
-------
gimp testcase i mentioned in the bug. works.
Also even with a significant test delay (250ms) the windows still nearly map \
immediately (for the initial damage event)
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106173/">http://git.reviewboard.kde.org/r/106173/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">to workaround that bug / issue The very first damage event will still \
cause a full repaint (with setReadyForPainting)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">gimp testcase i mentioned in the bug. works. Also even with a \
significant test delay (250ms) the windows still nearly map immediately (for the \
initial damage event)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295254">295254</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(09b0328)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(12bb75a)</span></li>
<li>kwin/effects.h <span style="color: grey">(014c4cf)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(f3fd7e5)</span></li>
<li>kwin/toplevel.h <span style="color: grey">(aba9321)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(9417813)</span></li>
<li>kwin/unmanaged.h <span style="color: grey">(b11d62b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106173/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic