[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Port of Plastik to QML
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-24 13:40:58
Message-ID: 20120824134058.13462.21604 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105768/
-----------------------------------------------------------
(Updated Aug. 24, 2012, 1:40 p.m.)
Review request for kwin.
Changes
-------
* use DecorationOptions inside Aurorae, too
Plastik QML is now almost on feature parity. I intend to push this branch b=
ut keep the "classic" decoration around till all features are ported over
Description (updated)
-------
This is the other part to the review request for QML support in Aurorae. Th=
e buttons are a little bit of cheating as they are rendered in C++ through =
an extension plugin.
Currently there are a few regressions compared to the native variant:
* animations are enforced (no option) - I intend to keep it that way
* colored border option is not supported, I'm not really sure what it actua=
lly does
* title alignment option not yet supported
* explicit button spacer is too small
* corners are not yet rounded
Overall the config options are missing, need to investigate how to do that.
Diffs (updated)
-----
kwin/clients/aurorae/CMakeLists.txt f5eeb71 =
kwin/clients/aurorae/src/CMakeLists.txt 71be39a =
kwin/clients/aurorae/src/aurorae.h fabd828 =
kwin/clients/aurorae/src/aurorae.cpp 4277b65 =
kwin/clients/aurorae/src/colorhelper.h PRE-CREATION =
kwin/clients/aurorae/src/colorhelper.cpp PRE-CREATION =
kwin/clients/aurorae/src/decorationoptions.h PRE-CREATION =
kwin/clients/aurorae/src/decorationoptions.cpp PRE-CREATION =
kwin/clients/aurorae/src/decorationplugin.h PRE-CREATION =
kwin/clients/aurorae/src/decorationplugin.cpp PRE-CREATION =
kwin/clients/aurorae/src/kwindecoration.desktop PRE-CREATION =
kwin/clients/aurorae/src/qml/ButtonGroup.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/aurorae.qml acd6d7a =
kwin/clients/aurorae/src/qml/qmldir PRE-CREATION =
kwin/clients/aurorae/themes/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikbutton.h PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikplugin.h PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/qmldir PRE-CREATION =
kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml=
PRE-CREATION =
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml PRE-CREA=
TION =
kwin/clients/aurorae/themes/plastik/package/metadata.desktop PRE-CREATION =
kwin/kcmkwin/kwindecoration/CMakeLists.txt da02993 =
kwin/kcmkwin/kwindecoration/decorationmodel.h 0a5a116 =
kwin/kcmkwin/kwindecoration/decorationmodel.cpp 4915d10 =
kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209 =
kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml 8db4065 =
kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml PRE-CREATION =
kwin/kcmkwin/kwindecoration/qml/main.qml 9ca0e89 =
Diff: http://git.reviewboard.kde.org/r/105768/diff/
Testing
-------
Screenshots
-----------
Old and new Plastik
http://git.reviewboard.kde.org/r/105768/s/648/
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105768/">http://git.reviewboard.kde.org/r/105768/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2012, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* use DecorationOptions inside Aurorae, too
Plastik QML is now almost on feature parity. I intend to push this branch but keep \
the "classic" decoration around till all features are ported over</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the other part to the review request for QML support in Aurorae. \
The buttons are a little bit of cheating as they are rendered in C++ through an \
extension plugin.
Currently there are a few regressions compared to the native variant:
* animations are enforced (no option) - I intend to keep it that way
* colored border option is not supported, I'm not really sure what it actually \
does
* title alignment option not yet supported
* explicit button spacer is too small
* corners are not yet rounded
Overall the config options are missing, need to investigate how to do that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/CMakeLists.txt <span style="color: \
grey">(f5eeb71)</span></li>
<li>kwin/clients/aurorae/src/CMakeLists.txt <span style="color: \
grey">(71be39a)</span></li>
<li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(fabd828)</span></li>
<li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(4277b65)</span></li>
<li>kwin/clients/aurorae/src/colorhelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/colorhelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationoptions.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationoptions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/kwindecoration.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/ButtonGroup.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/aurorae.qml <span style="color: \
grey">(acd6d7a)</span></li>
<li>kwin/clients/aurorae/src/qml/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style="color: \
grey">(da02993)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(0a5a116)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(4915d10)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(1f7a209)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml <span style="color: \
grey">(8db4065)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/main.qml <span style="color: \
grey">(9ca0e89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105768/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105768/s/648/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/28/plastik-qml-buttons_400x100.png" \
style="border: 1px black solid;" alt="Old and new Plastik" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic