'Review Request: Option to disable window close on menu double click in Aurorae'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Option to disable window close on menu double click in Aurorae
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-08-24 13:24:08
Message-ID: 20120824132408.10736.45980 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106160/
-----------------------------------------------------------

Review request for kwin.

Description
-------

For each theme the setting can be enabled individually with the
default being enabled by default. It is completely handled
inside the MenuButton QML component so each QML theme benefits
from the option automatically, too.

Based on the Plastik-QML review request as a parent.

This addresses bug 301327.
    http://bugs.kde.org/show_bug.cgi?id=301327

Diffs
-----

  kwin/clients/aurorae/src/qml/MenuButton.qml e2f67ec 
  kwin/kcmkwin/kwindecoration/auroraeconfig.ui 7762140 
  kwin/kcmkwin/kwindecoration/decorationmodel.h 0a5a116 
  kwin/kcmkwin/kwindecoration/decorationmodel.cpp 4915d10 
  kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209 

Diff: http://git.reviewboard.kde.org/r/106160/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106160/">http://git.reviewboard.kde.org/r/106160/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For each theme the setting can be enabled individually with the default \
being enabled by default. It is completely handled inside the MenuButton QML \
component so each QML theme benefits from the option automatically, too.

Based on the Plastik-QML review request as a parent.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=301327">301327</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/qml/MenuButton.qml <span style="color: \
grey">(e2f67ec)</span></li>

 <li>kwin/kcmkwin/kwindecoration/auroraeconfig.ui <span style="color: \
grey">(7762140)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(0a5a116)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(4915d10)</span></li>

 <li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(1f7a209)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106160/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 